You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/12/31 09:19:33 UTC
[GitHub] [rocketmq-exporter] cserwen opened a new pull request #87: [ISSUE #86] Convert humanReadable to machineReadable for commitLogDirCapacity
cserwen opened a new pull request #87:
URL: https://github.com/apache/rocketmq-exporter/pull/87
## What is the purpose of the change
#86
## Brief changelog
XX
## Verifying this change
XXXX
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-exporter] vongosling commented on a change in pull request #87: [ISSUE #86] Convert humanReadable to machineReadable for commitLogDirCapacity
Posted by GitBox <gi...@apache.org>.
vongosling commented on a change in pull request #87:
URL: https://github.com/apache/rocketmq-exporter/pull/87#discussion_r779253172
##########
File path: src/main/java/org/apache/rocketmq/exporter/model/BrokerRuntimeStats.java
##########
@@ -131,10 +131,22 @@ public BrokerRuntimeStats(KVTable kvTable) {
private void loadCommitLogDirCapacity(String commitLogDirCapacity) {
String[] arr = commitLogDirCapacity.split(" ");
- double total = Double.parseDouble(arr[2]);
- double free = Double.parseDouble(arr[6]);
- this.commitLogDirCapacityTotal = total;
- this.commitLogDirCapacityFree = free;
+ String total = String.format("%s %s", arr[2], arr[3].substring(0, arr[3].length() - 1));
+ String free = String.format("%s %s", arr[6], arr[7].substring(0, arr[7].length() - 1));
+ this.commitLogDirCapacityTotal = machineReadableByteCount(total);
+ this.commitLogDirCapacityFree = machineReadableByteCount(free);
+ }
+
+ private double machineReadableByteCount(String humanReadableValue) {
+ int unitSize = 1024;
+ String[] valueArray = humanReadableValue.split(" ");
Review comment:
More test would be nice:-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-exporter] cserwen commented on a change in pull request #87: [ISSUE #86] Convert humanReadable to machineReadable for commitLogDirCapacity
Posted by GitBox <gi...@apache.org>.
cserwen commented on a change in pull request #87:
URL: https://github.com/apache/rocketmq-exporter/pull/87#discussion_r779270656
##########
File path: src/main/java/org/apache/rocketmq/exporter/model/BrokerRuntimeStats.java
##########
@@ -131,10 +131,22 @@ public BrokerRuntimeStats(KVTable kvTable) {
private void loadCommitLogDirCapacity(String commitLogDirCapacity) {
String[] arr = commitLogDirCapacity.split(" ");
- double total = Double.parseDouble(arr[2]);
- double free = Double.parseDouble(arr[6]);
- this.commitLogDirCapacityTotal = total;
- this.commitLogDirCapacityFree = free;
+ String total = String.format("%s %s", arr[2], arr[3].substring(0, arr[3].length() - 1));
+ String free = String.format("%s %s", arr[6], arr[7].substring(0, arr[7].length() - 1));
+ this.commitLogDirCapacityTotal = machineReadableByteCount(total);
+ this.commitLogDirCapacityFree = machineReadableByteCount(free);
+ }
+
+ private double machineReadableByteCount(String humanReadableValue) {
+ int unitSize = 1024;
+ String[] valueArray = humanReadableValue.split(" ");
Review comment:
Thanks for your suggestion, I will add it later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-exporter] hdchen merged pull request #87: [ISSUE #86] Convert humanReadable to machineReadable for commitLogDirCapacity
Posted by GitBox <gi...@apache.org>.
hdchen merged pull request #87:
URL: https://github.com/apache/rocketmq-exporter/pull/87
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org