You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Zuyu Zhang <hi...@gmail.com> on 2014/08/18 17:40:03 UTC
Review Request 24804: Added Resources support to return the port
range for the given number of ports
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24804/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Repository: mesos-git
Description
-------
Added Resources support to return the port range for the given number of ports
Diffs
-----
include/mesos/resources.hpp 12adedc4429519b90f4975036f7359c20608708a
src/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43
Diff: https://reviews.apache.org/r/24804/diff/
Testing
-------
Thanks,
Zuyu Zhang
Re: Review Request 24804: Added Resources support to return the port
range for the given number of ports
Posted by Timothy Chen <tn...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24804/#review50899
-----------------------------------------------------------
src/common/resources.cpp
<https://reviews.apache.org/r/24804/#comment88774>
CHECK(numPorts > 0)
- Timothy Chen
On Aug. 18, 2014, 3:40 p.m., Zuyu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24804/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2014, 3:40 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added Resources support to return the port range for the given number of ports
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 12adedc4429519b90f4975036f7359c20608708a
> src/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43
>
> Diff: https://reviews.apache.org/r/24804/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zuyu Zhang
>
>
Re: Review Request 24804: Added Resources support to return the port
range for the given number of ports
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24804/#review50907
-----------------------------------------------------------
Patch looks great!
Reviews applied: [24804]
All tests passed.
- Mesos ReviewBot
On Aug. 18, 2014, 3:40 p.m., Zuyu Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24804/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2014, 3:40 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Added Resources support to return the port range for the given number of ports
>
>
> Diffs
> -----
>
> include/mesos/resources.hpp 12adedc4429519b90f4975036f7359c20608708a
> src/common/resources.cpp edf36b154174af18981db163b2a43d1255e2cc43
>
> Diff: https://reviews.apache.org/r/24804/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zuyu Zhang
>
>