You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/20 12:31:10 UTC

[GitHub] [spark] HyukjinKwon commented on a change in pull request #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry

HyukjinKwon commented on a change in pull request #27877: [SPARK-30541][TESTS] Implement KafkaDelegationTokenSuite with testRetry
URL: https://github.com/apache/spark/pull/27877#discussion_r395604822
 
 

 ##########
 File path: external/kafka-0-10-sql/src/test/scala/org/apache/spark/sql/kafka010/KafkaTestUtils.scala
 ##########
 @@ -74,6 +74,7 @@ class KafkaTestUtils(
   logInfo(s"Local host name is $localCanonicalHostName")
 
   private var kdc: MiniKdc = _
+  private var kdcDataDir: File = _
 
 Review comment:
   Hm, quick question. Is this related to the fix? I couldn't follow why we need to have this var.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org