You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "Fokko (via GitHub)" <gi...@apache.org> on 2024/12/03 21:16:17 UTC

[I] Write `null` for `current-snapshot-id` [iceberg-rust]

Fokko opened a new issue, #752:
URL: https://github.com/apache/iceberg-rust/issues/752

   Based on the checks in https://github.com/apache/iceberg-rust/pull/742#issuecomment-2515564242, it looks like we write `-1` when there is no snapshot, which is not correct.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Write `null` for `current-snapshot-id` [iceberg-rust]

Posted by "Fokko (via GitHub)" <gi...@apache.org>.
Fokko commented on issue #752:
URL: https://github.com/apache/iceberg-rust/issues/752#issuecomment-2516671564

   The [`writer-requirements` sections of the spec](https://iceberg.apache.org/spec/#writer-requirements) clarifies this:
   
   ![image](https://github.com/user-attachments/assets/1e628e30-ffb8-4e70-84cf-b2a190e9b296)
   
   The `current-snapshot-id` may be missing too since it is optional in V1. I think it is also fine for `properties`, `snapshots`, and `snapshot-log` to be missing if they are empty, this should all be handled fine by the reader.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Write `null` for `current-snapshot-id` [iceberg-rust]

Posted by "Xuanwo (via GitHub)" <gi...@apache.org>.
Xuanwo closed issue #752: Write `null` for `current-snapshot-id`
URL: https://github.com/apache/iceberg-rust/issues/752


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org


Re: [I] Write `null` for `current-snapshot-id` [iceberg-rust]

Posted by "c-thiel (via GitHub)" <gi...@apache.org>.
c-thiel commented on issue #752:
URL: https://github.com/apache/iceberg-rust/issues/752#issuecomment-2516657781

   @Fokko for this field but also others (properties, snapshots themselves, snapshot_log) should we skip serializing them if they are none or add `null`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org