Re: [PR] Add PostgreSQL `CREATE USER` and `ALTER USER` support [datafusion-sqlparser-rs]

["ramnes (via GitHub)" <gi...@apache.org>]

ramnes commented on code in PR #2015:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/2015#discussion_r2313348699


##########
src/ast/mod.rs:
##########
@@ -3314,6 +3314,8 @@ pub enum Statement {
     CreateRole {
         names: Vec<ObjectName>,
         if_not_exists: bool,
+        /// Whether ROLE or USER keyword was used
+        keyword: RoleKeyword,

Review Comment:
   We have a namespace problem here, because there's already a `CreateUser` structure for Snowflake semantics. In the grand scheme of things, `CreateUser` and `CreateRole` should probably be both compatible with both Snowflake and PostgreSQL? I'm not sure if I'm seasoned enough with the codebase to bring that in, and that would be a very different kind of work than this PR. :) 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org