You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2022/09/09 18:53:07 UTC
[GitHub] [fineract] hmg65 opened a new pull request, #2586: FINERACT-1736: Introduce Lombok to emailcampaigns module
hmg65 opened a new pull request, #2586:
URL: https://github.com/apache/fineract/pull/2586
## Description
Describe the changes made and why they were made.
Ignore if these details are present on the associated [Apache Fineract JIRA ticket](https://github.com/apache/fineract/pull/1284).
## Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
- [x] Write the commit message as per https://github.com/apache/fineract/#pull-requests
- [x] Acknowledge that we will not review PRs that are not passing the build _("green")_ - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
- [x] Create/update unit or integration tests for verifying the changes made.
- [x] Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
- [x] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
- [x] Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] hmg65 commented on a diff in pull request #2586: FINERACT-1736: Introduce Lombok to emailcampaigns module
Posted by GitBox <gi...@apache.org>.
hmg65 commented on code in PR #2586:
URL: https://github.com/apache/fineract/pull/2586#discussion_r971524313
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/EmailCampaign.java:
##########
@@ -192,9 +170,11 @@ public static EmailCampaign instance(final AppUser submittedBy, final Report bus
recurrenceStartDate = null;
}
- return new EmailCampaign(campaignName, campaignType.intValue(), businessRuleId, paramValue, emailSubject, emailMessage,
- submittedOnDate, submittedBy, stretchyReport, stretchyReportParamMap, emailAttachmentFileFormat, recurrence,
- recurrenceStartDate);
+ return new EmailCampaign().setCampaignName(campaignName).setCampaignType(campaignType.intValue()).setBusinessRuleId(businessRuleId)
Review Comment:
@galovics but 'status' is not there in the previous return statement. should I add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics merged pull request #2586: FINERACT-1736: Introduce Lombok to emailcampaigns module
Posted by GitBox <gi...@apache.org>.
galovics merged PR #2586:
URL: https://github.com/apache/fineract/pull/2586
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2586: FINERACT-1736: Introduce Lombok to emailcampaigns module
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2586:
URL: https://github.com/apache/fineract/pull/2586#discussion_r969643899
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/EmailCampaign.java:
##########
@@ -192,9 +170,11 @@ public static EmailCampaign instance(final AppUser submittedBy, final Report bus
recurrenceStartDate = null;
}
- return new EmailCampaign(campaignName, campaignType.intValue(), businessRuleId, paramValue, emailSubject, emailMessage,
- submittedOnDate, submittedBy, stretchyReport, stretchyReportParamMap, emailAttachmentFileFormat, recurrence,
- recurrenceStartDate);
+ return new EmailCampaign().setCampaignName(campaignName).setCampaignType(campaignType.intValue()).setBusinessRuleId(businessRuleId)
Review Comment:
I think this is missing:
this.status = EmailCampaignStatus.PENDING.getValue();
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] galovics commented on a diff in pull request #2586: FINERACT-1736: Introduce Lombok to emailcampaigns module
Posted by GitBox <gi...@apache.org>.
galovics commented on code in PR #2586:
URL: https://github.com/apache/fineract/pull/2586#discussion_r974065371
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/EmailCampaign.java:
##########
@@ -192,9 +170,11 @@ public static EmailCampaign instance(final AppUser submittedBy, final Report bus
recurrenceStartDate = null;
}
- return new EmailCampaign(campaignName, campaignType.intValue(), businessRuleId, paramValue, emailSubject, emailMessage,
- submittedOnDate, submittedBy, stretchyReport, stretchyReportParamMap, emailAttachmentFileFormat, recurrence,
- recurrenceStartDate);
+ return new EmailCampaign().setCampaignName(campaignName).setCampaignType(campaignType.intValue()).setBusinessRuleId(businessRuleId)
Review Comment:
It's not but the constructor it originally called set it, can you please check?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] hmg65 commented on a diff in pull request #2586: FINERACT-1736: Introduce Lombok to emailcampaigns module
Posted by GitBox <gi...@apache.org>.
hmg65 commented on code in PR #2586:
URL: https://github.com/apache/fineract/pull/2586#discussion_r971524313
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/EmailCampaign.java:
##########
@@ -192,9 +170,11 @@ public static EmailCampaign instance(final AppUser submittedBy, final Report bus
recurrenceStartDate = null;
}
- return new EmailCampaign(campaignName, campaignType.intValue(), businessRuleId, paramValue, emailSubject, emailMessage,
- submittedOnDate, submittedBy, stretchyReport, stretchyReportParamMap, emailAttachmentFileFormat, recurrence,
- recurrenceStartDate);
+ return new EmailCampaign().setCampaignName(campaignName).setCampaignType(campaignType.intValue()).setBusinessRuleId(businessRuleId)
Review Comment:
but 'status' is not there in the previous return statement. should I add it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] hmg65 commented on a diff in pull request #2586: FINERACT-1736: Introduce Lombok to emailcampaigns module
Posted by GitBox <gi...@apache.org>.
hmg65 commented on code in PR #2586:
URL: https://github.com/apache/fineract/pull/2586#discussion_r974616693
##########
fineract-provider/src/main/java/org/apache/fineract/infrastructure/campaigns/email/domain/EmailCampaign.java:
##########
@@ -192,9 +170,11 @@ public static EmailCampaign instance(final AppUser submittedBy, final Report bus
recurrenceStartDate = null;
}
- return new EmailCampaign(campaignName, campaignType.intValue(), businessRuleId, paramValue, emailSubject, emailMessage,
- submittedOnDate, submittedBy, stretchyReport, stretchyReportParamMap, emailAttachmentFileFormat, recurrence,
- recurrenceStartDate);
+ return new EmailCampaign().setCampaignName(campaignName).setCampaignType(campaignType.intValue()).setBusinessRuleId(businessRuleId)
Review Comment:
made changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@fineract.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org