[GitHub] [spark] wangyum commented on a diff in pull request #38073: [SPARK-40632][SQL] Do not inject runtime filter if join condition reference non simple expression

[GitBox <gi...@apache.org>]

wangyum commented on code in PR #38073:
URL: https://github.com/apache/spark/pull/38073#discussion_r985322459


##########
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/InjectRuntimeFilter.scala:
##########
@@ -281,6 +289,7 @@ object InjectRuntimeFilter extends Rule[LogicalPlan] with PredicateHelper with J
       case join @ ExtractEquiJoinKeys(joinType, leftKeys, rightKeys, _, _, left, right, hint) =>
         var newLeft = left
         var newRight = right
+        val attributeMap = AttributeMap(join.children.flatMap(getAliasMap))

Review Comment:
   Yes. It get the original expression from the children if the condition is `AttributeReference`:
   <img width="361" alt="image" src="https://user-images.githubusercontent.com/5399861/193483694-a1de6253-9e27-4555-a383-398f25118682.png">



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org