You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/08/03 03:46:28 UTC
[GitHub] [incubator-doris] morningman opened a new pull request #6365: [Alter] Support doing compaction for tablets under alter operation
morningman opened a new pull request #6365:
URL: https://github.com/apache/incubator-doris/pull/6365
## Proposed changes
The problem I want to solve is described in #6355.
This CL mainly changes:
1. Support compacting tablets under alter operations
On BE side, the compaction logic will select tablets which state is "TABLET_NOTREADY" to do cumulative compaction.
2. Remove "alter_task" field in tablet's meta on BE side.
"alter_task" field is never used long time ago
3. Support doing delete operation when table is doing alter operation.
Previously, when a table is doing alter operation, execution of delete will return error: Table's state is not NORMAL.
But now, delete can be executed successfully, and delete condition will be applied to all materialized indexes.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [x] I have created an issue on (Fix #6355) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman merged pull request #6365: [Alter] Support doing compaction for tablets under alter operation
Posted by GitBox <gi...@apache.org>.
morningman merged pull request #6365:
URL: https://github.com/apache/incubator-doris/pull/6365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] morningman commented on a change in pull request #6365: [Alter] Support doing compaction for tablets under alter operation
Posted by GitBox <gi...@apache.org>.
morningman commented on a change in pull request #6365:
URL: https://github.com/apache/incubator-doris/pull/6365#discussion_r683934447
##########
File path: be/src/olap/cumulative_compaction_policy.cpp
##########
@@ -68,40 +68,55 @@ void SizeBasedCumulativeCompactionPolicy::calculate_cumulative_point(
// calculate promotion size
auto base_rowset_meta = existing_rss.begin();
- // check base rowset first version must be zero
- CHECK((*base_rowset_meta)->start_version() == 0);
- int64_t promotion_size = 0;
- _calc_promotion_size(*base_rowset_meta, &promotion_size);
+ if (tablet->tablet_state() == TABLET_RUNNING) {
+ // check base rowset first version must be zero
+ // for tablet which state is not TABLET_RUNNING, there may not have base version.
+ CHECK((*base_rowset_meta)->start_version() == 0);
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6365: [Alter] Support doing compaction for tablets under alter operation
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6365:
URL: https://github.com/apache/incubator-doris/pull/6365#issuecomment-893993785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #6365: [Alter] Support doing compaction for tablets under alter operation
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #6365:
URL: https://github.com/apache/incubator-doris/pull/6365#discussion_r683063839
##########
File path: be/src/olap/cumulative_compaction_policy.cpp
##########
@@ -68,40 +68,55 @@ void SizeBasedCumulativeCompactionPolicy::calculate_cumulative_point(
// calculate promotion size
auto base_rowset_meta = existing_rss.begin();
- // check base rowset first version must be zero
- CHECK((*base_rowset_meta)->start_version() == 0);
- int64_t promotion_size = 0;
- _calc_promotion_size(*base_rowset_meta, &promotion_size);
+ if (tablet->tablet_state() == TABLET_RUNNING) {
+ // check base rowset first version must be zero
+ // for tablet which state is not TABLET_RUNNING, there may not have base version.
+ CHECK((*base_rowset_meta)->start_version() == 0);
Review comment:
move to next if block ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg commented on a change in pull request #6365: [Alter] Support doing compaction for tablets under alter operation
Posted by GitBox <gi...@apache.org>.
yangzhg commented on a change in pull request #6365:
URL: https://github.com/apache/incubator-doris/pull/6365#discussion_r683063839
##########
File path: be/src/olap/cumulative_compaction_policy.cpp
##########
@@ -68,40 +68,55 @@ void SizeBasedCumulativeCompactionPolicy::calculate_cumulative_point(
// calculate promotion size
auto base_rowset_meta = existing_rss.begin();
- // check base rowset first version must be zero
- CHECK((*base_rowset_meta)->start_version() == 0);
- int64_t promotion_size = 0;
- _calc_promotion_size(*base_rowset_meta, &promotion_size);
+ if (tablet->tablet_state() == TABLET_RUNNING) {
+ // check base rowset first version must be zero
+ // for tablet which state is not TABLET_RUNNING, there may not have base version.
+ CHECK((*base_rowset_meta)->start_version() == 0);
Review comment:
move to next if block ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org