[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #994: MINIFICPP-1434: Fix flaky CSite2SiteTests on macOS

[GitBox <gi...@apache.org>]

martinzink commented on pull request #994:
URL: https://github.com/apache/nifi-minifi-cpp/pull/994#issuecomment-774072591


   The issue is that on macOS the default sigpipe handler crashes the application.
   In production code we are already ignoring this by setting the sigpipe handle to nothing. see https://github.com/apache/nifi-minifi-cpp/blob/main/main/MiNiFiMain.cpp#L181
   Given this I think it would be appropriate to ignore it in these tests as well.
   
   I've tested this on my fork with custom CI, on both macos-xcode12.0 and macos-xcode11.2.1 with 200 runs
   `make test ARGS="--timeout 300 -j4 --output-on-failure -R CSite2SiteTests --repeat-until-fail 200`
   Without the fix both configuration failed (both around the 100th run), with the fix they passed 3 times (thats 1200 runs without failure)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org