You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "aleksandr-dudko (via GitHub)" <gi...@apache.org> on 2023/09/21 21:52:12 UTC
[GitHub] [beam] aleksandr-dudko opened a new pull request, #28602: Add GitHub Workflow Replacements for Jenkins job_PerformanceTests_JDBC
aleksandr-dudko opened a new pull request, #28602:
URL: https://github.com/apache/beam/pull/28602
PR migrates Jenkins Jobs to Github Actions Workflow:
".github/workflows/beam_PerformanceTests_JDBC"
Jenkins Jobs:
https://ci-beam.apache.org/view/PerformanceTests/job/beam_PerformanceTests_JDBC/
The code has been tested on Self-hosted GKE runners ubuntu 20.04.
Example runs:
beam_PerformanceTests_JDBC https://github.com/aleksandr-dudko/beam/actions/runs/6266173351

------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andreydevyatkin commented on a diff in pull request #28602: Add GitHub Workflow Replacements for Jenkins job_PerformanceTests_JDBC
Posted by "andreydevyatkin (via GitHub)" <gi...@apache.org>.
andreydevyatkin commented on code in PR #28602:
URL: https://github.com/apache/beam/pull/28602#discussion_r1339818817
##########
.github/workflows/beam_PerformanceTests_JDBC.yml:
##########
@@ -0,0 +1,108 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PerformanceTests JDBC
+
+on:
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '30 1,13 * * *'
Review Comment:
should be `30 1/13 * * *` in accordance with the Jenkins pattern
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #28602: Add GitHub Workflow Replacements for Jenkins job_PerformanceTests_JDBC
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #28602:
URL: https://github.com/apache/beam/pull/28602
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28602: Add GitHub Workflow Replacements for Jenkins job_PerformanceTests_JDBC
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28602:
URL: https://github.com/apache/beam/pull/28602#issuecomment-1739129667
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andreydevyatkin commented on a diff in pull request #28602: Add GitHub Workflow Replacements for Jenkins job_PerformanceTests_JDBC
Posted by "andreydevyatkin (via GitHub)" <gi...@apache.org>.
andreydevyatkin commented on code in PR #28602:
URL: https://github.com/apache/beam/pull/28602#discussion_r1339801965
##########
.github/workflows/beam_PerformanceTests_BiqQueryIO_Read_Python.yml:
##########
@@ -13,7 +13,7 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-name: Performance BigQueryIO Read Python
+name: PerformanceTests BiqQueryIO Read Python
Review Comment:
nit: remove extra whitespace
##########
.github/workflows/beam_PerformanceTests_BiqQueryIO_Read_Python.yml:
##########
@@ -69,29 +69,25 @@ jobs:
comment_phrase: ${{ matrix.job_phrase }}
github_token: ${{ secrets.GITHUB_TOKEN }}
github_job: ${{ matrix.job_name }} (${{ matrix.job_phrase }})
- - name: Install Python
- uses: actions/setup-python@v4
+ - name: Setup environment
+ uses: ./.github/actions/setup-environment-action
with:
- python-version: '3.8'
- # This code block prepares configuration data for a task.
- - name: Prepare config
- id: set_config
- shell: bash
- run: |
- # Capture the current date and time in a specific format
- CURDATE=$(date '+%m%d%H%M%S' --utc)
- # Reads the configurations file and exclude lines starting with # and then remove line breaks
- CURCONFIG=$(grep -v "^#.*" ./.github/workflows/performance-tests-job-configs/config_PerformanceTests_BiqQueryIO_Read_Python.txt | tr '\n' ' ')
- # Appends the value of CURDATE to the original configuration
- CONFIGWITHDATE=$(echo "${CURCONFIG/bqio_read_python_/bqio_read_python_$CURDATE}")
- # Assigns $CONFIGWITHDATE to a variable named prepared_config
- echo "prepared_config=$CONFIGWITHDATE" >> $GITHUB_OUTPUT
- - name: run BigQueryIO Read Python Performance Test
+ python-version: 3.8
+ - name: Prepare test arguments
+ uses: ./.github/actions/test-arguments-action
+ with:
+ test-type: load
+ test-language: python
+ argument-file-paths: |
+ ${{ github.workspace }}/.github/workflows/performance-tests-job-configs/biqQueryIO_Read_Python.txt
+ arguments: |
+ --job_name=performance-tests-bqio-read-python-10gb$(date '+%m%d%H%M%S' --utc)
+ - name: Run BigQueryIO Read Performance Test Python
uses: ./.github/actions/gradle-command-self-hosted-action
with:
gradle-command: :sdks:python:apache_beam:testing:load_tests:run
arguments: |
-PloadTest.mainClass=apache_beam.io.gcp.bigquery_read_perf_test \
-PpythonVersion=3.8 \
-Prunner=DataflowRunner \
- '-PloadTest.args=${{steps.set_config.outputs.prepared_config}}'
\ No newline at end of file
+ '-PloadTest.args=${{env.beam_PerformanceTests_BiqQueryIO_Read_Python_test_arguments_1}}'
Review Comment:
Please declare this variable above in the `env` section so that the linter does not display a warning. Please do this for all workflow files in the PR.
##########
.github/workflows/performance-tests-job-configs/jDBC.txt:
##########
@@ -0,0 +1,30 @@
+###############################################################################
Review Comment:
Please remove these multiple symbols, there is no need to section the license header.
##########
.github/workflows/beam_PerformanceTests_JDBC.yml:
##########
@@ -0,0 +1,108 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PerformanceTests JDBC
+
+on:
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '30 1,13 * * *'
Review Comment:
should be `30 1/13 * * *` in accordance with the Jenkins pattern
##########
.github/workflows/beam_PerformanceTests_JDBC.yml:
##########
@@ -0,0 +1,108 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+name: PerformanceTests JDBC
+
+on:
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '30 1,13 * * *'
+ workflow_dispatch:
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: write
+ checks: write
+ contents: read
+ deployments: read
+ id-token: none
+ issues: write
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.body || github.event.sender.login }}'
+ cancel-in-progress: true
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+jobs:
+ beam_PerformanceTests_JDBC:
+ if: |
+ github.event_name == 'workflow_dispatch' ||
+ github.event_name == 'schedule' ||
+ github.event.comment.body == 'Run Java JdbcIO Performance Test'
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 240
Review Comment:
should be `100`
##########
.github/workflows/performance-tests-job-configs/JDBC.txt:
##########
@@ -0,0 +1,29 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
Review Comment:
nit: please fix the formatting
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org