You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/04 21:50:05 UTC

[GitHub] [spark] nchammas commented on a change in pull request #27459: [SPARK-30510][SQL][Docs] Publicly document Spark SQL configuration options

nchammas commented on a change in pull request #27459: [SPARK-30510][SQL][Docs] Publicly document Spark SQL configuration options
URL: https://github.com/apache/spark/pull/27459#discussion_r374938777
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/api/python/PythonSQLUtils.scala
 ##########
 @@ -39,6 +40,11 @@ private[sql] object PythonSQLUtils {
     FunctionRegistry.functionSet.flatMap(f => FunctionRegistry.builtin.lookupFunction(f)).toArray
   }
 
+  def listSQLConfigs(): Array[(String, String, String)] = {
+    val conf = new SQLConf()
+    conf.getAllDefinedConfs.toArray
 
 Review comment:
   The original `Seq` wouldn't translate over into Python, so I had to convert this to an `Array`. I wonder if there's a cleaner way to do this.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org