[GitHub] [inlong] baomingyu commented on a diff in pull request #5965: [INLONG-5963][Audit] Solve the sdk memory leak problem

[GitBox <gi...@apache.org>]

baomingyu commented on code in PR #5965:
URL: https://github.com/apache/inlong/pull/5965#discussion_r975130848


##########
inlong-audit/audit-sdk/src/main/java/org/apache/inlong/audit/send/SenderGroup.java:
##########
@@ -110,6 +110,7 @@ public SenderResult send(ByteBuf dataBuf) {
             }
             if (channel == null) {
                 logger.error("can not get a channel");
+                dataBuf.release();

Review Comment:
   here need release too
   if (channels.size() <= 0) {
                   logger.error("channels is empty");
                   return new SenderResult("channels is empty", 0, false);
               } 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org