[jira] [Commented] (HBASE-4478) Improve AssignmentManager.handleRegion so that it can process certain ZK state in the case of RS offline

["ramkrishna.s.vasudevan (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-4478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146919#comment-13146919 ] 

ramkrishna.s.vasudevan commented on HBASE-4478:
-----------------------------------------------

Took up this issue
-> Am planning to continue progress only for FAILED_OPEN, CLOSED,

Because if we allow for OPENED any way the RS in which it opened is not alive in this case 
and also if we allow progress we will update it to OPEN and delete the node.  Any way this info is not valid any more as the RS itself is not alive.

For OPENING and CLOSING state if we allow then unnecessarily we will delay the timeout monitor from triggering new assign or unassign call.
Correct me if am wrong.  Will submit a patch sooner.


                
> Improve AssignmentManager.handleRegion so that it can process certain ZK state in the case of RS offline
> --------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4478
>                 URL: https://issues.apache.org/jira/browse/HBASE-4478
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Ming Ma
>            Assignee: Ming Ma
>
> Currently AssignmentManager.handleRegion skips processing of ZK event change if the RS is offline. It relies on TimeoutMonitor and ServerShutdownHandler to process RIT.
>       // Verify this is a known server
>       if (!serverManager.isServerOnline(sn) &&
>           !this.master.getServerName().equals(sn)) {
>         LOG.warn("Attempted to handle region transition for server but " +
>           "server is not online: " + Bytes.toString(data.getRegionName()));
>         return;
>       }
> For certain states like OPENED, OPENING, FAILED_OPEN, CLOSED, it can continue the progressing even if the RS is offline.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira