You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/02/11 09:29:37 UTC
[GitHub] [incubator-shardingsphere] terrymanu opened a new pull request
#4237: Use identifier value to instead of name and quote character in
SQLSegment
terrymanu opened a new pull request #4237: Use identifier value to instead of name and quote character in SQLSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4237
For #3914.
Changes proposed in this pull request:
- Use identifier value to instead of name and quote character in TableSegment
- Use identifier value to instead of name and quote character in SchemaSegment
- Use identifier value to instead of name and quote character in ColumnSegment
- Use identifier value to instead of name and quote character in IndexSegment
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4237: Use
identifier value to instead of name and quote character in SQLSegment
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4237: Use identifier value to instead of name and quote character in SQLSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4237#issuecomment-584558821
## Pull Request Test Coverage Report for [Build 1678](https://coveralls.io/builds/28651939)
* **68** of **108** **(62.96%)** changed or added relevant lines in **43** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.07%**) to **64.736%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/judgement/impl/PreparedJudgementEngine.java](https://coveralls.io/builds/28651939/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Fjudgement%2Fimpl%2FPreparedJudgementEngine.java#L82) | 1 | 2 | 50.0%
| [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/token/generator/impl/RemoveShadowColumnTokenGenerator.java](https://coveralls.io/builds/28651939/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FRemoveShadowColumnTokenGenerator.java#L53) | 0 | 1 | 0.0%
| [shadow-core/shadow-core-rewrite/src/main/java/org/apache/shardingsphere/shadow/rewrite/token/generator/impl/ShadowPredicateColumnTokenGenerator.java](https://coveralls.io/builds/28651939/source?filename=shadow-core%2Fshadow-core-rewrite%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshadow%2Frewrite%2Ftoken%2Fgenerator%2Fimpl%2FShadowPredicateColumnTokenGenerator.java#L61) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/index/IndexExtractor.java](https://coveralls.io/builds/28651939/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Findex%2FIndexExtractor.java#L41) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/common/schema/SchemaExtractor.java](https://coveralls.io/builds/28651939/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fcommon%2Fschema%2FSchemaExtractor.java#L41) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/impl/dml/select/item/impl/ShorthandProjectionExtractor.java](https://coveralls.io/builds/28651939/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fimpl%2Fdml%2Fselect%2Fitem%2Fimpl%2FShorthandProjectionExtractor.java#L51) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/core/filler/impl/dal/SchemaFiller.java](https://coveralls.io/builds/28651939/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Ffiller%2Fimpl%2Fdal%2FSchemaFiller.java#L35) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-engine/src/main/java/org/apache/shardingsphere/sql/parser/sql/segment/dml/item/ColumnProjectionSegment.java](https://coveralls.io/builds/28651939/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-engine%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fsegment%2Fdml%2Fitem%2FColumnProjectionSegment.java#L39) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/core/extractor/dal/MySQLShowLikeExtractor.java](https://coveralls.io/builds/28651939/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fcore%2Fextractor%2Fdal%2FMySQLShowLikeExtractor.java#L47) | 0 | 1 | 0.0%
| [shardingsphere-sql-parser/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/visitor/MySQLDMLVisitor.java](https://coveralls.io/builds/28651939/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fvisitor%2FMySQLDMLVisitor.java#L352) | 0 | 1 | 0.0%
<!-- | **Total:** | **68** | **108** | **62.96%** | -->
| Totals | [](https://coveralls.io/builds/28651939) |
| :-- | --: |
| Change from base [Build 817](https://coveralls.io/builds/28648911): | 0.07% |
| Covered Lines: | 11020 |
| Relevant Lines: | 17023 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] tuohai666 merged pull request #4237: Use
identifier value to instead of name and quote character in SQLSegment
Posted by GitBox <gi...@apache.org>.
tuohai666 merged pull request #4237: Use identifier value to instead of name and quote character in SQLSegment
URL: https://github.com/apache/incubator-shardingsphere/pull/4237
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services