[GitHub] [ozone] sodonnel commented on a change in pull request #2335: HDDS-4940 : EC: Implement the ECKeyOutputStream which should handle the EC mode writes.

[GitBox <gi...@apache.org>]

sodonnel commented on a change in pull request #2335:
URL: https://github.com/apache/ozone/pull/2335#discussion_r657866780



##########
File path: hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/scm/pipeline/Pipeline.java
##########
@@ -71,7 +71,7 @@
    * ContainerStateManager#getMatchingContainerByPipeline to take a lock on
    * the container allocations for a particular pipeline.
    */
-  private Pipeline(PipelineID id,

Review comment:
       Right now Pipeline is an immutable object, and this changes that. There is a comment in the pipeline class:
   
   ```  /**
      * The immutable properties of pipeline object is used in
      * ContainerStateManager#getMatchingContainerByPipeline to take a lock on
      * the container allocations for a particular pipeline.
      */
   ```
   
   I feel it would probably be better to keep these methods private as they are now and use the builder to create a pipeline object where needed.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org