You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/17 11:37:08 UTC
[GitHub] [superset] kgabryje opened a new pull request #17798: chore(plugin-chart-pivot-table): change order of Columns and Rows controls
kgabryje opened a new pull request #17798:
URL: https://github.com/apache/superset/pull/17798
### SUMMARY
Since column headers are visually above rows, it feels more logical to place the columns control above the rows control.
This PR changes the order of those controls
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
CC @kasiazjc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #17798: chore(plugin-chart-pivot-table): change order of Columns and Rows controls
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #17798:
URL: https://github.com/apache/superset/pull/17798#issuecomment-996694093
# [Codecov](https://codecov.io/gh/apache/superset/pull/17798?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#17798](https://codecov.io/gh/apache/superset/pull/17798?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1ecca35) into [master](https://codecov.io/gh/apache/superset/commit/9c9edbe8bc482a70109bbf368ba6ca8d4633bdf2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (9c9edbe) will **not change** coverage.
> The diff coverage is `n/a`.
> :exclamation: Current head 1ecca35 differs from pull request most recent head c7d4c2d. Consider uploading reports for the commit c7d4c2d to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/17798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #17798 +/- ##
=======================================
Coverage 67.18% 67.18%
=======================================
Files 1609 1609
Lines 64796 64796
Branches 6855 6855
=======================================
Hits 43530 43530
Misses 19410 19410
Partials 1856 1856
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `53.90% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/17798?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ugin-chart-pivot-table/src/plugin/controlPanel.tsx](https://codecov.io/gh/apache/superset/pull/17798/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvcGx1Z2lucy9wbHVnaW4tY2hhcnQtcGl2b3QtdGFibGUvc3JjL3BsdWdpbi9jb250cm9sUGFuZWwudHN4) | `12.50% <ø> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/17798?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/17798?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [9c9edbe...c7d4c2d](https://codecov.io/gh/apache/superset/pull/17798?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje merged pull request #17798: chore(plugin-chart-pivot-table): change order of Columns and Rows controls
Posted by GitBox <gi...@apache.org>.
kgabryje merged pull request #17798:
URL: https://github.com/apache/superset/pull/17798
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro commented on a change in pull request #17798: chore(plugin-chart-pivot-table): change order of Columns and Rows controls
Posted by GitBox <gi...@apache.org>.
villebro commented on a change in pull request #17798:
URL: https://github.com/apache/superset/pull/17798#discussion_r771329743
##########
File path: superset-frontend/plugins/plugin-chart-pivot-table/src/plugin/controlPanel.tsx
##########
@@ -95,10 +95,14 @@ const config: ControlPanelConfig = {
name: 'row_limit',
config: {
...sharedControls.row_limit,
+ label: t('Cell limit'),
+ description: t('Limits the number of cells that get displayed.'),
Review comment:
Maybe this is more accurate?
```suggestion
description: t('Limits the number of cells that get retieved.'),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org