You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@thrift.apache.org by je...@apache.org on 2020/01/19 21:19:12 UTC
[thrift] branch master updated: THRIFT-5051: Fix Python tutorials
to address THRIFT-4002 Client: Python Patch: Kengo Seki
This is an automated email from the ASF dual-hosted git repository.
jensg pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/thrift.git
The following commit(s) were added to refs/heads/master by this push:
new 46554d0 THRIFT-5051: Fix Python tutorials to address THRIFT-4002 Client: Python Patch: Kengo Seki
46554d0 is described below
commit 46554d0a4c741a886bf1e2cb9e0dd529eb94a387
Author: Kengo Seki <se...@apache.org>
AuthorDate: Fri Dec 27 07:56:12 2019 +0900
THRIFT-5051: Fix Python tutorials to address THRIFT-4002
Client: Python
Patch: Kengo Seki
This closes #1968
---
tutorial/py.tornado/PythonServer.py | 10 ++--------
tutorial/py.twisted/PythonServer.py | 10 ++--------
tutorial/py/PythonServer.py | 10 ++--------
3 files changed, 6 insertions(+), 24 deletions(-)
diff --git a/tutorial/py.tornado/PythonServer.py b/tutorial/py.tornado/PythonServer.py
index e0229a2..b472195 100755
--- a/tutorial/py.tornado/PythonServer.py
+++ b/tutorial/py.tornado/PythonServer.py
@@ -58,16 +58,10 @@ class CalculatorHandler(object):
val = work.num1 * work.num2
elif work.op == Operation.DIVIDE:
if work.num2 == 0:
- x = InvalidOperation()
- x.whatOp = work.op
- x.why = "Cannot divide by 0"
- raise x
+ raise InvalidOperation(work.op, "Cannot divide by 0")
val = work.num1 / work.num2
else:
- x = InvalidOperation()
- x.whatOp = work.op
- x.why = "Invalid operation"
- raise x
+ raise InvalidOperation(work.op, "Invalid operation")
log = SharedStruct()
log.key = logid
diff --git a/tutorial/py.twisted/PythonServer.py b/tutorial/py.twisted/PythonServer.py
index 034e4a3..c3e64db 100755
--- a/tutorial/py.twisted/PythonServer.py
+++ b/tutorial/py.twisted/PythonServer.py
@@ -60,16 +60,10 @@ class CalculatorHandler:
val = work.num1 * work.num2
elif work.op == Operation.DIVIDE:
if work.num2 == 0:
- x = InvalidOperation()
- x.whatOp = work.op
- x.why = 'Cannot divide by 0'
- raise x
+ raise InvalidOperation(work.op, 'Cannot divide by 0')
val = work.num1 / work.num2
else:
- x = InvalidOperation()
- x.whatOp = work.op
- x.why = 'Invalid operation'
- raise x
+ raise InvalidOperation(work.op, 'Invalid operation')
log = SharedStruct()
log.key = logid
diff --git a/tutorial/py/PythonServer.py b/tutorial/py/PythonServer.py
index e6421ef..d2343ed 100755
--- a/tutorial/py/PythonServer.py
+++ b/tutorial/py/PythonServer.py
@@ -57,16 +57,10 @@ class CalculatorHandler:
val = work.num1 * work.num2
elif work.op == Operation.DIVIDE:
if work.num2 == 0:
- x = InvalidOperation()
- x.whatOp = work.op
- x.why = 'Cannot divide by 0'
- raise x
+ raise InvalidOperation(work.op, 'Cannot divide by 0')
val = work.num1 / work.num2
else:
- x = InvalidOperation()
- x.whatOp = work.op
- x.why = 'Invalid operation'
- raise x
+ raise InvalidOperation(work.op, 'Invalid operation')
log = SharedStruct()
log.key = logid