You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by GitBox <gi...@apache.org> on 2023/01/09 08:28:34 UTC
[GitHub] [inlong] haifxu opened a new pull request, #7193: [INLONG-7175][Agent] Support PostgreSQL Source
haifxu opened a new pull request, #7193:
URL: https://github.com/apache/inlong/pull/7193
### Prepare a Pull Request
- Fixes #7174
### Motivation
Support converting DataConfig to TriggerProfile for PostgreSQL.
### Modifications
Add `PostgresJob` and `POSTGRES` case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] pocozh commented on a diff in pull request #7193: [INLONG-7175][Agent] Support PostgreSQL Source
Posted by GitBox <gi...@apache.org>.
pocozh commented on code in PR #7193:
URL: https://github.com/apache/inlong/pull/7193#discussion_r1065294236
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/pojo/PostgresJob.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.agent.pojo;
+
+import lombok.Data;
+
+import java.util.List;
+import java.util.Map;
+
+/**
+ * PostgresJob : postgres job
+ */
+@Data
+public class PostgresJob {
+
+ private String username;
+ private String password;
+ private String hostname;
+ private Integer port;
+ private String database;
+ private String schema;
+ private String decodingPluginName;
+ private List<String> tableNameList;
+ private String serverTimeZone;
+ private String scanStartupMode;
+ private String primaryKey;
+ private Map<String, Object> properties;
+
+ @Data
+ public static class PostgresJobConfig {
+
+ private String username;
+ private String password;
+ private String hostname;
+ private Integer port;
+ private String database;
+ private String schema;
+ private String decodingPluginName;
+ private List<String> tableNameList;
+ private String serverTimeZone;
+ private String scanStartupMode;
+ private String primaryKey;
+ private Map<String, Object> properties;
Review Comment:
Please make sure the types of `port`, `tableNameList` and `properties` from InLong-Manager.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7193: [INLONG-7175][Agent] Support PostgreSQL Source
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #7193:
URL: https://github.com/apache/inlong/pull/7193#discussion_r1067746410
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/pojo/JobProfileDto.java:
##########
@@ -52,6 +52,10 @@ public class JobProfileDto {
* kafka source
*/
public static final String KAFKA_SOURCE = "org.apache.inlong.agent.plugin.sources.KafkaSource";
+ /**
+ * Postgres source
+ */
+ public static final String POSTGRES_SOURCE = "org.apache.inlong.agent.plugin.sources.PostgreSQLSource";
Review Comment:
Postgres -> PostgreSQL
POSTGRES_SOURCE -> POSTGRESQL_SOURCE
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow commented on a diff in pull request #7193: [INLONG-7175][Agent] Support converting DataConfig to TriggerProfile for PostgreSQL
Posted by GitBox <gi...@apache.org>.
healchow commented on code in PR #7193:
URL: https://github.com/apache/inlong/pull/7193#discussion_r1070804112
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/pojo/PostgreSQLJob.java:
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.agent.pojo;
+
+import lombok.Data;
+
+import java.util.List;
+
+/**
+ * PostgresJob : postgres job
Review Comment:
```suggestion
* PostgreSQL Job info
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] pocozh commented on a diff in pull request #7193: [INLONG-7175][Agent] Support PostgreSQL Source
Posted by GitBox <gi...@apache.org>.
pocozh commented on code in PR #7193:
URL: https://github.com/apache/inlong/pull/7193#discussion_r1066629006
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/pojo/PostgresJob.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.agent.pojo;
+
+import lombok.Data;
+
+import java.util.List;
+import java.util.Map;
+
+/**
+ * PostgresJob : postgres job
+ */
+@Data
+public class PostgresJob {
Review Comment:
Class name and field names should be consistent with definitions in `PostgreSQLReader`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] healchow merged pull request #7193: [INLONG-7174][Agent] Support converting DataConfig to TriggerProfile for PostgreSQL
Posted by GitBox <gi...@apache.org>.
healchow merged PR #7193:
URL: https://github.com/apache/inlong/pull/7193
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] haifxu commented on a diff in pull request #7193: [INLONG-7175][Agent] Support PostgreSQL Source
Posted by GitBox <gi...@apache.org>.
haifxu commented on code in PR #7193:
URL: https://github.com/apache/inlong/pull/7193#discussion_r1066664697
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/pojo/PostgresJob.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.agent.pojo;
+
+import lombok.Data;
+
+import java.util.List;
+import java.util.Map;
+
+/**
+ * PostgresJob : postgres job
+ */
+@Data
+public class PostgresJob {
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] haifxu commented on a diff in pull request #7193: [INLONG-7175][Agent] Support PostgreSQL Source
Posted by GitBox <gi...@apache.org>.
haifxu commented on code in PR #7193:
URL: https://github.com/apache/inlong/pull/7193#discussion_r1065624603
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/pojo/PostgresJob.java:
##########
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.inlong.agent.pojo;
+
+import lombok.Data;
+
+import java.util.List;
+import java.util.Map;
+
+/**
+ * PostgresJob : postgres job
+ */
+@Data
+public class PostgresJob {
+
+ private String username;
+ private String password;
+ private String hostname;
+ private Integer port;
+ private String database;
+ private String schema;
+ private String decodingPluginName;
+ private List<String> tableNameList;
+ private String serverTimeZone;
+ private String scanStartupMode;
+ private String primaryKey;
+ private Map<String, Object> properties;
+
+ @Data
+ public static class PostgresJobConfig {
+
+ private String username;
+ private String password;
+ private String hostname;
+ private Integer port;
+ private String database;
+ private String schema;
+ private String decodingPluginName;
+ private List<String> tableNameList;
+ private String serverTimeZone;
+ private String scanStartupMode;
+ private String primaryKey;
+ private Map<String, Object> properties;
Review Comment:
Type conversion has been added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [inlong] haifxu commented on a diff in pull request #7193: [INLONG-7175][Agent] Support PostgreSQL Source
Posted by GitBox <gi...@apache.org>.
haifxu commented on code in PR #7193:
URL: https://github.com/apache/inlong/pull/7193#discussion_r1068842591
##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/pojo/JobProfileDto.java:
##########
@@ -52,6 +52,10 @@ public class JobProfileDto {
* kafka source
*/
public static final String KAFKA_SOURCE = "org.apache.inlong.agent.plugin.sources.KafkaSource";
+ /**
+ * Postgres source
+ */
+ public static final String POSTGRES_SOURCE = "org.apache.inlong.agent.plugin.sources.PostgreSQLSource";
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org