You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "gnodet (via GitHub)" <gi...@apache.org> on 2025/04/25 09:26:44 UTC
[PR] Add generated file warning headers to velocity templates [maven-resolver]
gnodet opened a new pull request, #691:
URL: https://github.com/apache/maven-resolver/pull/691
Add comment headers to velocity templates to indicate that the generated files should not be modified directly. The headers include information about the source template and instructions to modify the template instead of the generated file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add generated file warning headers to velocity templates [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #691:
URL: https://github.com/apache/maven-resolver/pull/691
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add generated file warning headers to velocity templates [maven-resolver]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on PR #691:
URL: https://github.com/apache/maven-resolver/pull/691#issuecomment-2847959273
> OK as a temporary stopgap, but in general generated files shouldn't even be in the source repo.
but this is template that will be used to generate files - and expectation is that generated files will have this comment included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add generated file warning headers to velocity templates [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #691:
URL: https://github.com/apache/maven-resolver/pull/691#issuecomment-2848017024
> OK as a temporary stopgap, but in general generated files shouldn't even be in the source repo.
This is a limitation of site/doxia: it cannot process generated resources, at least not in this way. Personally, I'd get rid of this, but cannot do due Doxia/Site stuff.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add generated file warning headers to velocity templates [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #691:
URL: https://github.com/apache/maven-resolver/pull/691#issuecomment-2848586484
Is markdown supported? And can i enlist the generated file in site.xml as a side menu entry?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add generated file warning headers to velocity templates [maven-resolver]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #691:
URL: https://github.com/apache/maven-resolver/pull/691#issuecomment-2848054878
> > OK as a temporary stopgap, but in general generated files shouldn't even be in the source repo.
>
> This is a limitation of site/doxia: it cannot process generated resources, at least not in this way. Personally, I'd get rid of this, but cannot do due Doxia/Site stuff.
Not correct, it can as long as it is a supported format: https://maven.apache.org/plugins/maven-site-plugin/site-mojo.html#generatedSiteDirectory
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add generated file warning headers to velocity templates [maven-resolver]
Posted by "michael-o (via GitHub)" <gi...@apache.org>.
michael-o commented on PR #691:
URL: https://github.com/apache/maven-resolver/pull/691#issuecomment-2848595314
> Is markdown supported? And can i enlist the generated file in site.xml as a side menu entry?
Yes, that that is no problem. The structure is identical to src/site.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add generated file warning headers to velocity templates [maven-resolver]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on PR #691:
URL: https://github.com/apache/maven-resolver/pull/691#issuecomment-2848697478
> Yes, that that is no problem. The structure is identical to src/site.
Cool! Resolver and Maven would gladly accept a PR that is fixing this :smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org