You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@struts.apache.org by perfnorm <gi...@git.apache.org> on 2015/10/09 13:35:07 UTC
[GitHub] struts pull request: Make it easier to extend to use own ActionInv...
GitHub user perfnorm opened a pull request:
https://github.com/apache/struts/pull/54
Make it easier to extend to use own ActionInvocation
I needed to extend DefaultActionProxyFactory to return my own ActionInvocation, but I had to override all of createActionProxy() to do so. Seems like a safe change to break out the ActionInvocation creation to make it easier to just override that piece.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/perfnorm/struts patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/struts/pull/54.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #54
----
commit 79a2022b55e48fb65e23f5be8d775c8006ce83e8
Author: Jasper <ja...@yahoo.com>
Date: 2015-10-09T11:34:31Z
Make it easier to extend to use own ActionInvocation
I needed to extend DefaultActionProxyFactory to return my own ActionInvocation, but I had to override all of createActionProxy() to do so. Seems like a safe change to break out the ActionInvocation creation to make it easier to just override that piece.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Make it easier to extend to use own ActionInv...
Posted by perfnorm <gi...@git.apache.org>.
Github user perfnorm commented on the pull request:
https://github.com/apache/struts/pull/54#issuecomment-146841479
Done, thanks @wolpi (also added for my other pull request)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Make it easier to extend to use own ActionInv...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/struts/pull/54
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org
[GitHub] struts pull request: Make it easier to extend to use own ActionInv...
Posted by wolpi <gi...@git.apache.org>.
Github user wolpi commented on the pull request:
https://github.com/apache/struts/pull/54#issuecomment-146840650
Please create a JIRA issue. That makes it easier to track changes and contributions.
https://issues.apache.org/jira/browse/WW
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@struts.apache.org
For additional commands, e-mail: dev-help@struts.apache.org