You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Sergey Shelukhin <se...@hortonworks.com> on 2017/04/21 02:51:15 UTC
Review Request 58601: HIVE-16233 llap: Query failed with
AllocatorOutOfMemoryException
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58601/
-----------------------------------------------------------
Review request for hive, Gopal V and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 771f588a38
llap-server/runtest.sh PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java c049d2799c
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapCacheableBuffer.java 5c0b6f3d07
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapDataBuffer.java 7d5c1014fb
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java 23796f65e8
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelFifoCachePolicy.java 761fd00443
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java 3973c8a3aa
llap-server/src/java/org/apache/hadoop/hive/llap/cache/SerDeLowLevelCacheImpl.java cd5bc9b0b4
llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java 51eb34e949
llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleBufferManager.java af7cf3d5f1
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java 294fb2b41f
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 03bc3ced35
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java 907200a6e3
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VectorDeserializeOrcWriter.java c9df7d94a0
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java a6080e63fa
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocatorDefrag.java PRE-CREATION
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java e95f807679
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java 0cce624682
pom.xml 5ec6befee6
storage-api/src/java/org/apache/hadoop/hive/common/io/Allocator.java 16b9713661
storage-api/src/java/org/apache/hadoop/hive/common/io/DataCache.java e53b737910
Diff: https://reviews.apache.org/r/58601/diff/1/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 58601: HIVE-16233 llap: Query failed with
AllocatorOutOfMemoryException
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58601/#review172578
-----------------------------------------------------------
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java
Lines 1305 (patched)
<https://reviews.apache.org/r/58601/#comment245669>
bogus comment
- Sergey Shelukhin
On April 21, 2017, 2:51 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58601/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 2:51 a.m.)
>
>
> Review request for hive, Gopal V and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 771f588a38
> llap-server/runtest.sh PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java c049d2799c
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapCacheableBuffer.java 5c0b6f3d07
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapDataBuffer.java 7d5c1014fb
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java 23796f65e8
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelFifoCachePolicy.java 761fd00443
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java 3973c8a3aa
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/SerDeLowLevelCacheImpl.java cd5bc9b0b4
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java 51eb34e949
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleBufferManager.java af7cf3d5f1
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java 294fb2b41f
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 03bc3ced35
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java 907200a6e3
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VectorDeserializeOrcWriter.java c9df7d94a0
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java a6080e63fa
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocatorDefrag.java PRE-CREATION
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java e95f807679
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java 0cce624682
> pom.xml 5ec6befee6
> storage-api/src/java/org/apache/hadoop/hive/common/io/Allocator.java 16b9713661
> storage-api/src/java/org/apache/hadoop/hive/common/io/DataCache.java e53b737910
>
>
> Diff: https://reviews.apache.org/r/58601/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 58601: HIVE-16233 llap: Query failed with
AllocatorOutOfMemoryException
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58601/
-----------------------------------------------------------
(Updated May 16, 2017, 9:53 p.m.)
Review request for hive, Gopal V and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1c37b6e091
llap-server/runtest.sh PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java 302918aadf
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapCacheableBuffer.java 5c0b6f3d07
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapDataBuffer.java 7d5c1014fb
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java 23796f65e8
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java 2132574fb5
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCachePolicy.java fd9d9420b9
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelFifoCachePolicy.java 761fd00443
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java 3973c8a3aa
llap-server/src/java/org/apache/hadoop/hive/llap/cache/MemoryManager.java 0f4d3c01d7
llap-server/src/java/org/apache/hadoop/hive/llap/cache/SerDeLowLevelCacheImpl.java cd5bc9b0b4
llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java 51eb34e949
llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleBufferManager.java af7cf3d5f1
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java 294fb2b41f
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 03bc3ced35
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java 907200a6e3
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VectorDeserializeOrcWriter.java c9df7d94a0
llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcFileEstimateErrors.java 20af0d0b49
llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcFileMetadata.java 2c7a234a08
llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcStripeMetadata.java 1f3f7ea05e
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java a6080e63fa
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocatorForceEvict.java PRE-CREATION
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java e95f807679
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java 0cce624682
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestOrcMetadataCache.java 3059382942
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 5b2e9b5b87
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java c81131e014
ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java a9c1e61ba9
storage-api/src/java/org/apache/hadoop/hive/common/io/Allocator.java 16b9713661
storage-api/src/java/org/apache/hadoop/hive/common/io/DataCache.java e53b737910
Diff: https://reviews.apache.org/r/58601/diff/4/
Changes: https://reviews.apache.org/r/58601/diff/3-4/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 58601: HIVE-16233 llap: Query failed with
AllocatorOutOfMemoryException
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58601/
-----------------------------------------------------------
(Updated May 16, 2017, 2:22 a.m.)
Review request for hive, Gopal V and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 1c37b6e091
llap-server/runtest.sh PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java 302918aadf
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapCacheableBuffer.java 5c0b6f3d07
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapDataBuffer.java 7d5c1014fb
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java 23796f65e8
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheMemoryManager.java 2132574fb5
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCachePolicy.java fd9d9420b9
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelFifoCachePolicy.java 761fd00443
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java 3973c8a3aa
llap-server/src/java/org/apache/hadoop/hive/llap/cache/MemoryManager.java 0f4d3c01d7
llap-server/src/java/org/apache/hadoop/hive/llap/cache/SerDeLowLevelCacheImpl.java cd5bc9b0b4
llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java 51eb34e949
llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleBufferManager.java af7cf3d5f1
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java 294fb2b41f
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 03bc3ced35
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java 907200a6e3
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VectorDeserializeOrcWriter.java c9df7d94a0
llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcFileEstimateErrors.java 20af0d0b49
llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcFileMetadata.java 2c7a234a08
llap-server/src/java/org/apache/hadoop/hive/llap/io/metadata/OrcStripeMetadata.java 1f3f7ea05e
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java a6080e63fa
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocatorForceEvict.java PRE-CREATION
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java e95f807679
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java 0cce624682
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestOrcMetadataCache.java 3059382942
ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java 5b2e9b5b87
ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/LlapDecider.java c81131e014
ql/src/java/org/apache/hadoop/hive/ql/parse/GenTezUtils.java a9c1e61ba9
storage-api/src/java/org/apache/hadoop/hive/common/io/Allocator.java 16b9713661
storage-api/src/java/org/apache/hadoop/hive/common/io/DataCache.java e53b737910
Diff: https://reviews.apache.org/r/58601/diff/3/
Changes: https://reviews.apache.org/r/58601/diff/2-3/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 58601: HIVE-16233 llap: Query failed with
AllocatorOutOfMemoryException
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58601/
-----------------------------------------------------------
(Updated April 26, 2017, 1:14 a.m.)
Review request for hive, Gopal V and Prasanth_J.
Repository: hive-git
Description
-------
see jira
Diffs (updated)
-----
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 8e5a9aa53d
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java c049d2799c
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java PRE-CREATION
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapCacheableBuffer.java 5c0b6f3d07
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapDataBuffer.java 7d5c1014fb
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java 23796f65e8
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelFifoCachePolicy.java 761fd00443
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java 3973c8a3aa
llap-server/src/java/org/apache/hadoop/hive/llap/cache/SerDeLowLevelCacheImpl.java cd5bc9b0b4
llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java 51eb34e949
llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleBufferManager.java af7cf3d5f1
llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java 294fb2b41f
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 03bc3ced35
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java 907200a6e3
llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VectorDeserializeOrcWriter.java c9df7d94a0
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java a6080e63fa
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocatorDefrag.java PRE-CREATION
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java e95f807679
llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java 0cce624682
storage-api/src/java/org/apache/hadoop/hive/common/io/Allocator.java 16b9713661
storage-api/src/java/org/apache/hadoop/hive/common/io/DataCache.java e53b737910
Diff: https://reviews.apache.org/r/58601/diff/2/
Changes: https://reviews.apache.org/r/58601/diff/1-2/
Testing
-------
Thanks,
Sergey Shelukhin
Re: Review Request 58601: HIVE-16233 llap: Query failed with
AllocatorOutOfMemoryException
Posted by Sergey Shelukhin <se...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58601/#review172577
-----------------------------------------------------------
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java
Lines 390 (patched)
<https://reviews.apache.org/r/58601/#comment245668>
(3) was removed to simplify logic. Will update comment
pom.xml
Line 190 (original), 190 (patched)
<https://reviews.apache.org/r/58601/#comment245667>
unrelated
- Sergey Shelukhin
On April 21, 2017, 2:51 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58601/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 2:51 a.m.)
>
>
> Review request for hive, Gopal V and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 771f588a38
> llap-server/runtest.sh PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java c049d2799c
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapCacheableBuffer.java 5c0b6f3d07
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapDataBuffer.java 7d5c1014fb
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java 23796f65e8
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelFifoCachePolicy.java 761fd00443
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java 3973c8a3aa
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/SerDeLowLevelCacheImpl.java cd5bc9b0b4
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java 51eb34e949
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleBufferManager.java af7cf3d5f1
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java 294fb2b41f
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 03bc3ced35
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java 907200a6e3
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VectorDeserializeOrcWriter.java c9df7d94a0
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java a6080e63fa
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocatorDefrag.java PRE-CREATION
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java e95f807679
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java 0cce624682
> pom.xml 5ec6befee6
> storage-api/src/java/org/apache/hadoop/hive/common/io/Allocator.java 16b9713661
> storage-api/src/java/org/apache/hadoop/hive/common/io/DataCache.java e53b737910
>
>
> Diff: https://reviews.apache.org/r/58601/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>
Re: Review Request 58601: HIVE-16233 llap: Query failed with
AllocatorOutOfMemoryException
Posted by j....@gmail.com.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58601/#review172833
-----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
Lines 2969 (patched)
<https://reviews.apache.org/r/58601/#comment245864>
I cannot comment on the file below. So commenting here.
llap-server/runtest.sh unintentional addition?
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java
Line 278 (original), 271 (patched)
<https://reviews.apache.org/r/58601/#comment245964>
any reason for >10? make it a static final value?
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java
Line 292 (original), 281 (patched)
<https://reviews.apache.org/r/58601/#comment245965>
same like above. make attempt static final.
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java
Lines 1773 (patched)
<https://reviews.apache.org/r/58601/#comment245983>
looks like INFO or DEBUG and not ERROR level.
llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java
Lines 1822 (patched)
<https://reviews.apache.org/r/58601/#comment245982>
nit: remove deadcode
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java
Lines 65 (patched)
<https://reviews.apache.org/r/58601/#comment245979>
assuming someone will notify when the state has changed from FLAG_MOVING to something else. I can see that this loop tries to wait until state change but I don't see anyone actually notify using state.notify(). Looks like every 10ms we keep retrying and checking state instead of actually using notify on state change.
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java
Lines 259 (patched)
<https://reviews.apache.org/r/58601/#comment245980>
this is where we probably want to notifyAll who are waiting on FLAG_MOVING state?
llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java
Lines 303 (patched)
<https://reviews.apache.org/r/58601/#comment245981>
better to add it here? caller doesn't seem to check.
- Prasanth_J
On April 21, 2017, 2:51 a.m., Sergey Shelukhin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58601/
> -----------------------------------------------------------
>
> (Updated April 21, 2017, 2:51 a.m.)
>
>
> Review request for hive, Gopal V and Prasanth_J.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> see jira
>
>
> Diffs
> -----
>
> common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 771f588a38
> llap-server/runtest.sh PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/BuddyAllocator.java c049d2799c
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapAllocatorBuffer.java PRE-CREATION
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapCacheableBuffer.java 5c0b6f3d07
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LlapDataBuffer.java 7d5c1014fb
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelCacheImpl.java 23796f65e8
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelFifoCachePolicy.java 761fd00443
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/LowLevelLrfuCachePolicy.java 3973c8a3aa
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/SerDeLowLevelCacheImpl.java cd5bc9b0b4
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleAllocator.java 51eb34e949
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/SimpleBufferManager.java af7cf3d5f1
> llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapIoImpl.java 294fb2b41f
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java 03bc3ced35
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java 907200a6e3
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VectorDeserializeOrcWriter.java c9df7d94a0
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocator.java a6080e63fa
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestBuddyAllocatorDefrag.java PRE-CREATION
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelCacheImpl.java e95f807679
> llap-server/src/test/org/apache/hadoop/hive/llap/cache/TestLowLevelLrfuCachePolicy.java 0cce624682
> pom.xml 5ec6befee6
> storage-api/src/java/org/apache/hadoop/hive/common/io/Allocator.java 16b9713661
> storage-api/src/java/org/apache/hadoop/hive/common/io/DataCache.java e53b737910
>
>
> Diff: https://reviews.apache.org/r/58601/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergey Shelukhin
>
>