[GitHub] [superset] geido edited a comment on pull request #18199: chore: Update links and navigation in Docusaurus

[GitBox <gi...@apache.org>]

geido edited a comment on pull request #18199:
URL: https://github.com/apache/superset/pull/18199#issuecomment-1024188887


   > I am not aware of any better place to discuss Docusaurus migration implementation. Please indicate such a place (if any), and I will transfer my comments. I have a few comments.
   > 
   > We have `docs-v2/package-lock.json` and `docs-v2/yarn.lock`. In addiction the project we have different package manager:
   > 
   > ```
   > $ find . -name 'package-lock.json' -o -name 'yarn.lock' | grep -v 'node_modules'
   > ./docs-v2/package-lock.json
   > ./docs-v2/yarn.lock
   > ./superset-websocket/package-lock.json
   > ./superset-websocket/utils/client-ws-app/package-lock.json
   > ./superset-frontend/temporary_superset_ui/superset-ui-plugins-deckgl/yarn.lock
   > ./superset-frontend/temporary_superset_ui/superset-ui/package-lock.json
   > ./superset-frontend/package-lock.json
   > ./superset-frontend/cypress-base/package-lock.json
   > ./docs/package-lock.json
   > ```
   > 
   > * [ ]  Can we use only one package manager for Docusaurus project?
   > * [ ]  In long term, can we make consistent which package manager we will gonna use in Superset's project?
   > 
   > In an attempt to build I receive a warning:
   > 
   > ```
   > Invalid docusaurus-plugin-client-redirects version 2.0.0-beta.14.
   > All official @docusaurus/* packages should have the exact same version as @docusaurus/core (2.0.0-beta.9).
   > Maybe you want to check, or regenerate your yarn.lock or package-lock.json file?
   > ```
   > 
   > * [ ]  Can we sync package versions as @docusaurus/* recommends?
   > 
   > Apache Foundation has "[Website Navigation Links Policy](https://www.apache.org/foundation/marks/pmcs#navigation)". I have the impression that we are not yet aligned with it.
   > 
   > * [x]  Can we add links to "Donate", "Thanks", "Security".
   > 
   > Let me know what you think, I am open to working on the above with you.
   
   Hey @ad-m thanks for reporting these. I had the same thoughts about the package and yarn locks, as well as that warning. If you think you can solve those problems that'd be great. I can definitely help you with that. Let's chat on Slack sometime soon.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org