You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/12/02 15:14:22 UTC
[GitHub] [arrow] jorisvandenbossche opened a new pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
jorisvandenbossche opened a new pull request #11840:
URL: https://github.com/apache/arrow/pull/11840
When using `console` highlighting, the `$` automatically is "not selectable" (when selecting for copy-pasting), which doesn't happen with the `shell` highlighting we were using.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF removed a comment on pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
AlenkaF removed a comment on pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#issuecomment-985367029
@jorisvandenbossche it could be just my build of the docs again, but `$` gets selected if I try to copy paste. Does it work for u?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche closed pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche closed pull request #11840:
URL: https://github.com/apache/arrow/pull/11840
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#issuecomment-985397689
@jorisvandenbossche probably it's jut my build of the docs again, but trying the `console` directive in another file `$` gets copy-pasted. Did you maybe try this on your build, does it work?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#discussion_r761192242
##########
File path: docs/source/developers/cpp/building.rst
##########
@@ -15,6 +15,8 @@
.. specific language governing permissions and limitations
.. under the License.
+.. highlight:: console
Review comment:
This sets the default for the full file. Alternative is specifying it for each code-block (like we now had 'shell' for each code block). The latter might actually be more explicit, so either way is fine for me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#discussion_r761268317
##########
File path: docs/source/conf.py
##########
@@ -70,7 +70,7 @@
'IPython.sphinxext.ipython_directive',
'IPython.sphinxext.ipython_console_highlighting',
'breathe',
- 'sphinx_tabs.tabs'
+ # 'sphinx_tabs.tabs'
Review comment:
Whoops, didn't mean to commit that. Yeah, the reason is that I had uninstalled it for updating sphinx (I should reinstall sphinx-tabs with pip, the latest version if not yet available with conda). Will revert this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a change in pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on a change in pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#discussion_r761206421
##########
File path: docs/source/developers/cpp/building.rst
##########
@@ -15,6 +15,8 @@
.. specific language governing permissions and limitations
.. under the License.
+.. highlight:: console
Review comment:
If there is a need to make a code block in another language I assume it supersedes the `console` set for the full file?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#issuecomment-988681874
Benchmark runs are scheduled for baseline = a400652507540b690f774f5e162c118d91594a50 and contender = b3dbe32771a4c954d42310234ce21e382fae1232. b3dbe32771a4c954d42310234ce21e382fae1232 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9c5064930d7c4c3ea21da79d3aceeaf1...e3896d3a7e0f42c7b9138a46092b085f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/85526bd2b32f4e618980a4fa523d08ed...6457a6c7c81c4cedb652f0b77e6757c5/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/87d001b3c3864d2fbcb8d24292d03fcb...65d7cbbeeced4419a0f6d79df43384b5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot commented on pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
ursabot commented on pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#issuecomment-988681874
Benchmark runs are scheduled for baseline = a400652507540b690f774f5e162c118d91594a50 and contender = b3dbe32771a4c954d42310234ce21e382fae1232. b3dbe32771a4c954d42310234ce21e382fae1232 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Scheduled] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9c5064930d7c4c3ea21da79d3aceeaf1...e3896d3a7e0f42c7b9138a46092b085f/)
[Scheduled] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/85526bd2b32f4e618980a4fa523d08ed...6457a6c7c81c4cedb652f0b77e6757c5/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/87d001b3c3864d2fbcb8d24292d03fcb...65d7cbbeeced4419a0f6d79df43384b5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on a change in pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#discussion_r761210418
##########
File path: docs/source/developers/cpp/building.rst
##########
@@ -15,6 +15,8 @@
.. specific language governing permissions and limitations
.. under the License.
+.. highlight:: console
Review comment:
> If there is a need to make a code block in another language I assume it supersedes the console set for the full file?
Yes, indeed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#issuecomment-988681874
Benchmark runs are scheduled for baseline = a400652507540b690f774f5e162c118d91594a50 and contender = b3dbe32771a4c954d42310234ce21e382fae1232. b3dbe32771a4c954d42310234ce21e382fae1232 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9c5064930d7c4c3ea21da79d3aceeaf1...e3896d3a7e0f42c7b9138a46092b085f/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/85526bd2b32f4e618980a4fa523d08ed...6457a6c7c81c4cedb652f0b77e6757c5/)
[Scheduled] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/87d001b3c3864d2fbcb8d24292d03fcb...65d7cbbeeced4419a0f6d79df43384b5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#issuecomment-984721848
(I should still check if this can also be done for other files)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on a change in pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on a change in pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#discussion_r761247000
##########
File path: docs/source/conf.py
##########
@@ -70,7 +70,7 @@
'IPython.sphinxext.ipython_directive',
'IPython.sphinxext.ipython_console_highlighting',
'breathe',
- 'sphinx_tabs.tabs'
+ # 'sphinx_tabs.tabs'
Review comment:
Just curious, did this make trouble that you needed to comment it out?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] AlenkaF commented on pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
AlenkaF commented on pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#issuecomment-985367029
@jorisvandenbossche it could be just my build of the docs again, but `$` gets selected if I try to copy paste. Does it work for u?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#discussion_r761204127
##########
File path: docs/source/developers/cpp/building.rst
##########
@@ -15,6 +15,8 @@
.. specific language governing permissions and limitations
.. under the License.
+.. highlight:: console
Review comment:
Are there other files where we should apply this? (or switch "shell" code blocks to "console"?)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jorisvandenbossche commented on pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
jorisvandenbossche commented on pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#issuecomment-984720728
cc @AlenkaF
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] ursabot edited a comment on pull request #11840: MINOR: [Docs] Use 'console' highlighting (instead of 'shell') for code blocks with $
Posted by GitBox <gi...@apache.org>.
ursabot edited a comment on pull request #11840:
URL: https://github.com/apache/arrow/pull/11840#issuecomment-988681874
Benchmark runs are scheduled for baseline = a400652507540b690f774f5e162c118d91594a50 and contender = b3dbe32771a4c954d42310234ce21e382fae1232. b3dbe32771a4c954d42310234ce21e382fae1232 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/9c5064930d7c4c3ea21da79d3aceeaf1...e3896d3a7e0f42c7b9138a46092b085f/)
[Finished :arrow_down:0.0% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/85526bd2b32f4e618980a4fa523d08ed...6457a6c7c81c4cedb652f0b77e6757c5/)
[Finished :arrow_down:0.18% :arrow_up:0.09%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/87d001b3c3864d2fbcb8d24292d03fcb...65d7cbbeeced4419a0f6d79df43384b5/)
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python. Runs only benchmarks with cloud = True
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org