You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Alexey Varlamov (JIRA)" <ji...@apache.org> on 2006/09/04 13:14:22 UTC
[jira] Created: (HARMONY-1376) [launcher] properties buffer may be
overflowed
[launcher] properties buffer may be overflowed
----------------------------------------------
Key: HARMONY-1376
URL: http://issues.apache.org/jira/browse/HARMONY-1376
Project: Harmony
Issue Type: Bug
Components: Classlib
Reporter: Alexey Varlamov
The launcher parses "harmonyvm.properties" into a buffer of fixed size and without boundaries checking.
If the file has more than 20 lines with VM arguments, segfault occurs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Closed: (HARMONY-1376) [launcher] properties buffer may be
overflowed
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1376?page=all ]
Geir Magnusson Jr closed HARMONY-1376.
--------------------------------------
works with windows too :)
> [launcher] properties buffer may be overflowed
> ----------------------------------------------
>
> Key: HARMONY-1376
> URL: http://issues.apache.org/jira/browse/HARMONY-1376
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Assigned To: Geir Magnusson Jr
> Attachments: H-1376.diff, H-1376.diff
>
>
> The launcher parses "harmonyvm.properties" into a buffer of fixed size and without boundaries checking.
> If the file has more than 20 lines with VM arguments, segfault occurs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1376) [launcher] properties buffer may be
overflowed
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1376?page=all ]
Alexey Varlamov updated HARMONY-1376:
-------------------------------------
Attachment: H-1376.diff
Fixed number of issues with "harmonyvm.properties":
1) Robust file parsing with any EOLs;
2) The buffer overflow mentioned above;
3) Added support for %VM_DIR% tokens, now easy to add any others;
4) Command-line "-Xbootclasspath:" option now really overrides whole BCP.
Also removed some unused parameters from internal declarations.
> [launcher] properties buffer may be overflowed
> ----------------------------------------------
>
> Key: HARMONY-1376
> URL: http://issues.apache.org/jira/browse/HARMONY-1376
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Attachments: H-1376.diff
>
>
> The launcher parses "harmonyvm.properties" into a buffer of fixed size and without boundaries checking.
> If the file has more than 20 lines with VM arguments, segfault occurs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1376) [launcher] properties buffer may
be overflowed
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1376?page=comments#action_12437067 ]
Geir Magnusson Jr commented on HARMONY-1376:
--------------------------------------------
Thanks. Staring. Only grumble is that you did some refactoring too unrelated to the fixing of properties handling, which is distracting. But still, nice work. Need to stare a bit more...
> [launcher] properties buffer may be overflowed
> ----------------------------------------------
>
> Key: HARMONY-1376
> URL: http://issues.apache.org/jira/browse/HARMONY-1376
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Assigned To: Geir Magnusson Jr
> Attachments: H-1376.diff, H-1376.diff
>
>
> The launcher parses "harmonyvm.properties" into a buffer of fixed size and without boundaries checking.
> If the file has more than 20 lines with VM arguments, segfault occurs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (HARMONY-1376) [launcher] properties buffer may be
overflowed
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1376?page=all ]
Geir Magnusson Jr reassigned HARMONY-1376:
------------------------------------------
Assignee: Geir Magnusson Jr
> [launcher] properties buffer may be overflowed
> ----------------------------------------------
>
> Key: HARMONY-1376
> URL: http://issues.apache.org/jira/browse/HARMONY-1376
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Assigned To: Geir Magnusson Jr
> Attachments: H-1376.diff
>
>
> The launcher parses "harmonyvm.properties" into a buffer of fixed size and without boundaries checking.
> If the file has more than 20 lines with VM arguments, segfault occurs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1376) [launcher] properties buffer may
be overflowed
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1376?page=comments#action_12437068 ]
Alexey Varlamov commented on HARMONY-1376:
------------------------------------------
I strived to not touch extra code unrelated to createVMArgs(), but there was a chain of unused params going quite deeply through the call stack - so I fixed all that in one shot. Sorry if it bothers...
Also, I had to enhance shared parser a bit - e.g. add a support for keys with empty values, etc. And this gets the parser closer to j.l.Properties.load() behavior.
> [launcher] properties buffer may be overflowed
> ----------------------------------------------
>
> Key: HARMONY-1376
> URL: http://issues.apache.org/jira/browse/HARMONY-1376
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Assigned To: Geir Magnusson Jr
> Attachments: H-1376.diff, H-1376.diff
>
>
> The launcher parses "harmonyvm.properties" into a buffer of fixed size and without boundaries checking.
> If the file has more than 20 lines with VM arguments, segfault occurs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (HARMONY-1376) [launcher] properties buffer may be
overflowed
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1376?page=all ]
Alexey Varlamov updated HARMONY-1376:
-------------------------------------
Attachment: H-1376.diff
Re-attached the same patch to fix download problems.
> [launcher] properties buffer may be overflowed
> ----------------------------------------------
>
> Key: HARMONY-1376
> URL: http://issues.apache.org/jira/browse/HARMONY-1376
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Assigned To: Geir Magnusson Jr
> Attachments: H-1376.diff, H-1376.diff
>
>
> The launcher parses "harmonyvm.properties" into a buffer of fixed size and without boundaries checking.
> If the file has more than 20 lines with VM arguments, segfault occurs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (HARMONY-1376) [launcher] properties buffer may
be overflowed
Posted by "Alexey Varlamov (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1376?page=comments#action_12438020 ]
Alexey Varlamov commented on HARMONY-1376:
------------------------------------------
Geir, are there any problems with the patch? Looks like you postponed it.
> [launcher] properties buffer may be overflowed
> ----------------------------------------------
>
> Key: HARMONY-1376
> URL: http://issues.apache.org/jira/browse/HARMONY-1376
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Assigned To: Geir Magnusson Jr
> Attachments: H-1376.diff, H-1376.diff
>
>
> The launcher parses "harmonyvm.properties" into a buffer of fixed size and without boundaries checking.
> If the file has more than 20 lines with VM arguments, segfault occurs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Resolved: (HARMONY-1376) [launcher] properties buffer may be
overflowed
Posted by "Geir Magnusson Jr (JIRA)" <ji...@apache.org>.
[ http://issues.apache.org/jira/browse/HARMONY-1376?page=all ]
Geir Magnusson Jr resolved HARMONY-1376.
----------------------------------------
Resolution: Fixed
r453631
Tested on ubuntu - needs to be tested on winXP as well
> [launcher] properties buffer may be overflowed
> ----------------------------------------------
>
> Key: HARMONY-1376
> URL: http://issues.apache.org/jira/browse/HARMONY-1376
> Project: Harmony
> Issue Type: Bug
> Components: Classlib
> Reporter: Alexey Varlamov
> Assigned To: Geir Magnusson Jr
> Attachments: H-1376.diff, H-1376.diff
>
>
> The launcher parses "harmonyvm.properties" into a buffer of fixed size and without boundaries checking.
> If the file has more than 20 lines with VM arguments, segfault occurs.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira