You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2021/01/18 05:22:09 UTC
[GitHub] [rocketmq] xxd763795151 opened a new pull request #2608: Set benchmark`s consumer isSuffixEnable default false and update help info
xxd763795151 opened a new pull request #2608:
URL: https://github.com/apache/rocketmq/pull/2608
1. Set the default value of isSuffixEnable which belong to benchmark`s consumer to false.
2. Update the help info abou isSuffixEnable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io edited a comment on pull request #2608: [ISSUE #2607] Set benchmark`s consumer isSuffixEnable default false and update help info
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #2608:
URL: https://github.com/apache/rocketmq/pull/2608#issuecomment-761998446
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=h1) Report
> Merging [#2608](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=desc) (7006d3a) into [develop](https://codecov.io/gh/apache/rocketmq/commit/6af12592af95916cc0b4512f2bab60ee18f62b8b?el=desc) (6af1259) will **increase** coverage by `0.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2608 +/- ##
=============================================
+ Coverage 45.80% 46.12% +0.32%
- Complexity 4306 4340 +34
=============================================
Files 547 547
Lines 36246 36246
Branches 4808 4808
=============================================
+ Hits 16601 16718 +117
+ Misses 17552 17434 -118
- Partials 2093 2094 +1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...mq/client/impl/consumer/RebalanceLitePullImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VMaXRlUHVsbEltcGwuamF2YQ==) | `49.15% <0.00%> (-5.09%)` | `10.00% <0.00%> (-1.00%)` | |
| [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `75.55% <0.00%> (-4.45%)` | `9.00% <0.00%> (-1.00%)` | |
| [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `57.67% <0.00%> (-4.19%)` | `31.00% <0.00%> (-1.00%)` | |
| [...client/consumer/store/RemoteBrokerOffsetStore.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvc3RvcmUvUmVtb3RlQnJva2VyT2Zmc2V0U3RvcmUuamF2YQ==) | `67.56% <0.00%> (-1.81%)` | `20.00% <0.00%> (-2.00%)` | |
| [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `41.51% <0.00%> (-1.09%)` | `19.00% <0.00%> (+3.00%)` | :arrow_down: |
| [...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==) | `73.60% <0.00%> (-0.51%)` | `17.00% <0.00%> (ø%)` | |
| [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `29.50% <0.00%> (ø)` | `26.00% <0.00%> (ø%)` | |
| [...etmq/client/latency/LatencyFaultToleranceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvbGF0ZW5jeS9MYXRlbmN5RmF1bHRUb2xlcmFuY2VJbXBsLmphdmE=) | `50.00% <0.00%> (ø)` | `8.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `66.52% <0.00%> (+0.10%)` | `79.00% <0.00%> (ø%)` | |
| [...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vUm91dGVJbmZvTWFuYWdlci5qYXZh) | `39.12% <0.00%> (+0.21%)` | `28.00% <0.00%> (+1.00%)` | |
| ... and [21 more](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=footer). Last update [6af1259...7006d3a](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] codecov-io commented on pull request #2608: [ISSUE #2607] Set benchmark`s consumer isSuffixEnable default false and update help info
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #2608:
URL: https://github.com/apache/rocketmq/pull/2608#issuecomment-761998446
# [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=h1) Report
> Merging [#2608](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=desc) (7006d3a) into [develop](https://codecov.io/gh/apache/rocketmq/commit/6af12592af95916cc0b4512f2bab60ee18f62b8b?el=desc) (6af1259) will **increase** coverage by `0.32%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #2608 +/- ##
=============================================
+ Coverage 45.80% 46.12% +0.32%
- Complexity 4306 4340 +34
=============================================
Files 547 547
Lines 36246 36246
Branches 4808 4808
=============================================
+ Hits 16601 16718 +117
+ Misses 17552 17434 -118
- Partials 2093 2094 +1
```
| [Impacted Files](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...mq/client/impl/consumer/RebalanceLitePullImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9SZWJhbGFuY2VMaXRlUHVsbEltcGwuamF2YQ==) | `49.15% <0.00%> (-5.09%)` | `10.00% <0.00%> (-1.00%)` | |
| [...ketmq/client/impl/consumer/PullMessageService.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9QdWxsTWVzc2FnZVNlcnZpY2UuamF2YQ==) | `75.55% <0.00%> (-4.45%)` | `9.00% <0.00%> (-1.00%)` | |
| [...he/rocketmq/client/impl/consumer/ProcessQueue.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Qcm9jZXNzUXVldWUuamF2YQ==) | `57.67% <0.00%> (-4.19%)` | `31.00% <0.00%> (-1.00%)` | |
| [...client/consumer/store/RemoteBrokerOffsetStore.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvY29uc3VtZXIvc3RvcmUvUmVtb3RlQnJva2VyT2Zmc2V0U3RvcmUuamF2YQ==) | `67.56% <0.00%> (-1.81%)` | `20.00% <0.00%> (-2.00%)` | |
| [...nt/impl/consumer/ConsumeMessageOrderlyService.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvaW1wbC9jb25zdW1lci9Db25zdW1lTWVzc2FnZU9yZGVybHlTZXJ2aWNlLmphdmE=) | `41.51% <0.00%> (-1.09%)` | `19.00% <0.00%> (+3.00%)` | :arrow_down: |
| [...he/rocketmq/client/trace/AsyncTraceDispatcher.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvdHJhY2UvQXN5bmNUcmFjZURpc3BhdGNoZXIuamF2YQ==) | `73.60% <0.00%> (-0.51%)` | `17.00% <0.00%> (ø%)` | |
| [...a/org/apache/rocketmq/store/StoreStatsService.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL1N0b3JlU3RhdHNTZXJ2aWNlLmphdmE=) | `29.50% <0.00%> (ø)` | `26.00% <0.00%> (ø%)` | |
| [...etmq/client/latency/LatencyFaultToleranceImpl.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-Y2xpZW50L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jbGllbnQvbGF0ZW5jeS9MYXRlbmN5RmF1bHRUb2xlcmFuY2VJbXBsLmphdmE=) | `50.00% <0.00%> (ø)` | `8.00% <0.00%> (ø%)` | |
| [...main/java/org/apache/rocketmq/store/CommitLog.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | `66.52% <0.00%> (+0.10%)` | `79.00% <0.00%> (ø%)` | |
| [...e/rocketmq/namesrv/routeinfo/RouteInfoManager.java](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree#diff-bmFtZXNydi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcm9ja2V0bXEvbmFtZXNydi9yb3V0ZWluZm8vUm91dGVJbmZvTWFuYWdlci5qYXZh) | `39.12% <0.00%> (+0.21%)` | `28.00% <0.00%> (+1.00%)` | |
| ... and [21 more](https://codecov.io/gh/apache/rocketmq/pull/2608/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=footer). Last update [6af1259...7006d3a](https://codecov.io/gh/apache/rocketmq/pull/2608?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2608: [ISSUE #2607] Set benchmark`s consumer isSuffixEnable default false and update help info
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2608:
URL: https://github.com/apache/rocketmq/pull/2608#issuecomment-761993127
[](https://coveralls.io/builds/36496276)
Coverage increased (+0.4%) to 52.061% when pulling **58cbf596abb0daa429d54719454c67d26be40cb8 on xxd763795151:bench_consumer** into **6af12592af95916cc0b4512f2bab60ee18f62b8b on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls edited a comment on pull request #2608: [ISSUE #2607] Set benchmark`s consumer isSuffixEnable default false and update help info
Posted by GitBox <gi...@apache.org>.
coveralls edited a comment on pull request #2608:
URL: https://github.com/apache/rocketmq/pull/2608#issuecomment-761993127
[](https://coveralls.io/builds/36496276)
Coverage increased (+0.4%) to 52.061% when pulling **58cbf596abb0daa429d54719454c67d26be40cb8 on xxd763795151:bench_consumer** into **6af12592af95916cc0b4512f2bab60ee18f62b8b on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] duhenglucky merged pull request #2608: [ISSUE #2607] Set benchmark`s consumer isSuffixEnable default false and update help info
Posted by GitBox <gi...@apache.org>.
duhenglucky merged pull request #2608:
URL: https://github.com/apache/rocketmq/pull/2608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] githublaohu commented on pull request #2608: [ISSUE #2607] Set benchmark`s consumer isSuffixEnable default false and update help info
Posted by GitBox <gi...@apache.org>.
githublaohu commented on pull request #2608:
URL: https://github.com/apache/rocketmq/pull/2608#issuecomment-762636195
不建议修改参数名。修改增加了熟悉成本。
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq] coveralls commented on pull request #2608: [ISSUE #2607] Set benchmark`s consumer isSuffixEnable default false and update help info
Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #2608:
URL: https://github.com/apache/rocketmq/pull/2608#issuecomment-761993127
[](https://coveralls.io/builds/36390524)
Coverage increased (+0.3%) to 51.95% when pulling **7006d3a8dbaf18ad6c71c941c6b8255dea904c13 on xxd763795151:bench_consumer** into **6af12592af95916cc0b4512f2bab60ee18f62b8b on apache:develop**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org