You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/03/28 17:48:47 UTC

[GitHub] [spark] srowen commented on issue #24235: [SPARK-27301][Dstream]Shorten the FileSystem cached life cycle to the cleanup method inner scope

srowen commented on issue #24235: [SPARK-27301][Dstream]Shorten the FileSystem cached life cycle to the cleanup method inner scope
URL: https://github.com/apache/spark/pull/24235#issuecomment-477703372
 
 
   I think this change is fine, in that it at least pushes the caching issue down into the library. No particular reason to 'cache' in Spark. However i agree it may not resolve the problem unless that library caching is disabled.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org