You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@calcite.apache.org by "Haisheng Yuan (Jira)" <ji...@apache.org> on 2020/06/22 22:09:00 UTC

[jira] [Created] (CALCITE-4083) RelTraitSet failed to canonize traits

Haisheng Yuan created CALCITE-4083:
--------------------------------------

             Summary: RelTraitSet failed to canonize traits
                 Key: CALCITE-4083
                 URL: https://issues.apache.org/jira/browse/CALCITE-4083
             Project: Calcite
          Issue Type: Bug
          Components: core
            Reporter: Haisheng Yuan


RelTraitSet#plus uses FlatLists and ImmutableList. They have different hash algorithms, and they are all different classes from RelTraitSet. The RelTraitSet equality requires the other object must be RelTraitSet too, and the HashMap#get(key) uses key.equals() to check equality, instead of the other way. In case we pass RelTraitSet as the search key to cache, but the cached entry has key with FlatLists or ImmutableList, we may fail to find the cached RelTraitSet. Due to this, using == to check traitSet equality may fail, even they have same traits.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)