You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "lizhimins (via GitHub)" <gi...@apache.org> on 2023/11/08 08:21:35 UTC
[PR] [ISSUE #7545] [RIP-65] Support efficient random index for massive mes… [rocketmq]
lizhimins opened a new pull request, #7546:
URL: https://github.com/apache/rocketmq/pull/7546
…sages
<!-- Please make sure the target branch is right. In most case, the target branch should be `develop`. -->
### Which Issue(s) This PR Fixes
<!-- Please ensure that the related issue has already been created, and [link this pull request to that issue using keywords](<https://docs.github.com/en/issues/tracking-your-work-with-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword>) to ensure automatic closure. -->
Support #7545
### Brief Description
<!-- Write a brief description for your pull request to help the maintainer understand the reasons behind your changes. -->
### How Did You Test This Change?
<!-- In order to ensure the code quality of Apache RocketMQ, we expect every pull request to have undergone thorough testing. -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7545] [RIP-65] Support efficient random index for massive messages [rocketmq]
Posted by "joeCarf (via GitHub)" <gi...@apache.org>.
joeCarf commented on code in PR #7546:
URL: https://github.com/apache/rocketmq/pull/7546#discussion_r1387394970
##########
tieredstore/src/main/java/org/apache/rocketmq/tieredstore/file/TieredConsumeQueue.java:
##########
@@ -20,9 +20,9 @@
import java.nio.ByteBuffer;
import java.util.concurrent.CompletableFuture;
import org.apache.commons.lang3.tuple.Pair;
+import org.apache.rocketmq.common.BoundaryType;
Review Comment:
no need to change this file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7545] [RIP-65] Support efficient random index for massive messages [rocketmq]
Posted by "lizhimins (via GitHub)" <gi...@apache.org>.
lizhimins merged PR #7546:
URL: https://github.com/apache/rocketmq/pull/7546
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [ISSUE #7545] [RIP-65] Support efficient random index for massive messages [rocketmq]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #7546:
URL: https://github.com/apache/rocketmq/pull/7546#issuecomment-1818742778
## [Codecov](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `171 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`46962c2`)](https://app.codecov.io/gh/apache/rocketmq/commit/46962c262c37554ff09afe9e02c7baf66a5ecc73?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 42.97% compared to head [(`723a7b9`)](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 43.28%.
> Report is 9 commits behind head on develop.
> :exclamation: Current head 723a7b9 differs from pull request most recent head 5438490. Consider uploading reports for the commit 5438490 to get more accurate results
| [Files](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [...che/rocketmq/tieredstore/index/IndexStoreFile.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL2luZGV4L0luZGV4U3RvcmVGaWxlLmphdmE=) | 77.50% | [35 Missing and 19 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../rocketmq/tieredstore/index/IndexStoreService.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL2luZGV4L0luZGV4U3RvcmVTZXJ2aWNlLmphdmE=) | 74.86% | [32 Missing and 14 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...che/rocketmq/tieredstore/TieredMessageFetcher.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL1RpZXJlZE1lc3NhZ2VGZXRjaGVyLmphdmE=) | 0.00% | [28 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...main/java/org/apache/rocketmq/store/CommitLog.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL0NvbW1pdExvZy5qYXZh) | 59.09% | [7 Missing and 11 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...a/org/apache/rocketmq/store/MessageExtEncoder.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL01lc3NhZ2VFeHRFbmNvZGVyLmphdmE=) | 78.26% | [3 Missing and 7 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [.../java/org/apache/rocketmq/store/MultiDispatch.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL011bHRpRGlzcGF0Y2guamF2YQ==) | 87.09% | [0 Missing and 4 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...rocketmq/common/message/MessageExtBrokerInner.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vbWVzc2FnZS9NZXNzYWdlRXh0QnJva2VySW5uZXIuamF2YQ==) | 25.00% | [3 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...org/apache/rocketmq/common/utils/MessageUtils.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Y29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9yb2NrZXRtcS9jb21tb24vdXRpbHMvTWVzc2FnZVV0aWxzLmphdmE=) | 88.00% | [0 Missing and 3 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...cketmq/tieredstore/file/TieredFlatFileManager.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-dGllcmVkc3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3RpZXJlZHN0b3JlL2ZpbGUvVGllcmVkRmxhdEZpbGVNYW5hZ2VyLmphdmE=) | 72.72% | [1 Missing and 2 partials :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [...pache/rocketmq/store/queue/MultiDispatchUtils.java](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c3RvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3JvY2tldG1xL3N0b3JlL3F1ZXVlL011bHRpRGlzcGF0Y2hVdGlscy5qYXZh) | 0.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| ... and [1 more](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## develop #7546 +/- ##
=============================================
+ Coverage 42.97% 43.28% +0.31%
- Complexity 9677 9789 +112
=============================================
Files 1158 1162 +4
Lines 83987 84223 +236
Branches 10917 10933 +16
=============================================
+ Hits 36093 36460 +367
+ Misses 43399 43245 -154
- Partials 4495 4518 +23
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/rocketmq/pull/7546?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org