You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/12/06 09:31:29 UTC
[GitHub] [beam] daria-malkova commented on a change in pull request #16119: [BEAM-13363][Playground] Add pipeline options support for Examples API
daria-malkova commented on a change in pull request #16119:
URL: https://github.com/apache/beam/pull/16119#discussion_r762833819
##########
File path: playground/backend/internal/cloud_bucket/precompiled_objects.go
##########
@@ -44,11 +44,12 @@ const (
)
type ObjectInfo struct {
- Name string
- CloudPath string
- Description string `protobuf:"bytes,3,opt,name=description,proto3" json:"description,omitempty"`
- Type pb.PrecompiledObjectType `protobuf:"varint,4,opt,name=type,proto3,enum=api.v1.PrecompiledObjectType" json:"type,omitempty"`
- Categories []string `json:"categories,omitempty"`
+ Name string
+ CloudPath string
+ Description string `protobuf:"bytes,3,opt,name=description,proto3" json:"description,omitempty"`
+ Type pb.PrecompiledObjectType `protobuf:"varint,4,opt,name=type,proto3,enum=api.v1.PrecompiledObjectType" json:"type,omitempty"`
+ Categories []string `json:"categories,omitempty"`
+ PipelineOptions string `protobuf:"bytes,3,opt,name=pipeline_options,proto3" json:"pipeline_options,omitempty"`
Review comment:
Now it the pipeline_options are empty, they will be omitted. Is it fine for PrecompiledObject message?
##########
File path: playground/backend/internal/cloud_bucket/precompiled_objects.go
##########
@@ -44,11 +44,12 @@ const (
)
type ObjectInfo struct {
- Name string
- CloudPath string
- Description string `protobuf:"bytes,3,opt,name=description,proto3" json:"description,omitempty"`
- Type pb.PrecompiledObjectType `protobuf:"varint,4,opt,name=type,proto3,enum=api.v1.PrecompiledObjectType" json:"type,omitempty"`
- Categories []string `json:"categories,omitempty"`
+ Name string
+ CloudPath string
+ Description string `protobuf:"bytes,3,opt,name=description,proto3" json:"description,omitempty"`
+ Type pb.PrecompiledObjectType `protobuf:"varint,4,opt,name=type,proto3,enum=api.v1.PrecompiledObjectType" json:"type,omitempty"`
+ Categories []string `json:"categories,omitempty"`
+ PipelineOptions string `protobuf:"bytes,3,opt,name=pipeline_options,proto3" json:"pipeline_options,omitempty"`
Review comment:
Now if the pipeline_options are empty, they will be omitted. Is it fine for PrecompiledObject message?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org