You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/12/09 18:11:05 UTC

[GitHub] [superset] kasiazjc commented on pull request #17700: fix(Sql Lab tabs): Empty SQL lab tabs

kasiazjc commented on pull request #17700:
URL: https://github.com/apache/superset/pull/17700#issuecomment-990098874


   Hi! I agree that adding an error message is quite agressive as there is no real reason why user cannot have all of the tabs closed (and they may want to have like this for their peace of mind). 
   
   I would say that the easiest way to go and most user friendly would be improving an error state, below is a solution that I'd like to propose 
   
   ![image](https://user-images.githubusercontent.com/36897697/145451704-e301de2c-d211-4264-9cd0-bfbf9a98e1f5.png)
   
   ![sql empty state](https://user-images.githubusercontent.com/36897697/145452135-11f4c680-1351-4efd-b7f3-c6c1125d0c8f.gif)
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org