[GitHub] [doris] xiaokang commented on a diff in pull request #20889: [fix](compaction) fix time series compaction policy to adjust vertical compaction max segment size

["xiaokang (via GitHub)" <gi...@apache.org>]

xiaokang commented on code in PR #20889:
URL: https://github.com/apache/doris/pull/20889#discussion_r1231788682


##########
be/src/olap/compaction.cpp:
##########
@@ -126,6 +126,10 @@ int64_t Compaction::get_avg_segment_rows() {
     // input_rowsets_size is total disk_size of input_rowset, this size is the
     // final size after codec and compress, so expect dest segment file size
     // in disk is config::vertical_compaction_max_segment_size
+    if (config::compaction_policy == "time_series") {

Review Comment:
   use const instead of string literal



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org