You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/01/07 08:17:00 UTC
[jira] [Work logged] (BEAM-11358) Merge redundant metrics from
nexmark monitors and remove unused monitor from endOfStreamMonitor
[ https://issues.apache.org/jira/browse/BEAM-11358?focusedWorklogId=532322&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-532322 ]
ASF GitHub Bot logged work on BEAM-11358:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Jan/21 08:16
Start Date: 07/Jan/21 08:16
Worklog Time Spent: 10m
Work Description: echauchot commented on a change in pull request #13435:
URL: https://github.com/apache/beam/pull/13435#discussion_r553170443
##########
File path: sdks/java/testing/nexmark/src/main/java/org/apache/beam/sdk/nexmark/Monitor.java
##########
@@ -39,20 +39,15 @@
private class MonitorDoFn extends DoFn<T, T> {
final Counter elementCounter = Metrics.counter(name, prefix + ".elements");
final Counter bytesCounter = Metrics.counter(name, prefix + ".bytes");
- final Distribution startTime = Metrics.distribution(name, prefix + ".startTime");
- final Distribution endTime = Metrics.distribution(name, prefix + ".endTime");
- final Distribution startTimestamp = Metrics.distribution(name, prefix + ".startTimestamp");
- final Distribution endTimestamp = Metrics.distribution(name, prefix + ".endTimestamp");
+ final Distribution systemTimestamp = Metrics.distribution(name, prefix + ".systemTimestamp");
Review comment:
please rename also the metric name
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 532322)
Time Spent: 2h 50m (was: 2h 40m)
> Merge redundant metrics from nexmark monitors and remove unused monitor from endOfStreamMonitor
> ------------------------------------------------------------------------------------------------
>
> Key: BEAM-11358
> URL: https://issues.apache.org/jira/browse/BEAM-11358
> Project: Beam
> Issue Type: Improvement
> Components: testing-nexmark
> Affects Versions: 2.25.0
> Reporter: Teodor Spæren
> Assignee: Teodor Spæren
> Priority: P2
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> The endOfStreamMonitor in the NexmarkQuery class is not used. The monitor class also had start and end distributions, which used the same values. This PR removes the unused monitor and merges the start and end distributions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)