You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Vinayakumar B (Jira)" <ji...@apache.org> on 2020/01/16 18:17:00 UTC

[jira] [Resolved] (HADOOP-16621) [pb-upgrade] Remove Protobuf classes from signatures of Public APIs

     [ https://issues.apache.org/jira/browse/HADOOP-16621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Vinayakumar B resolved HADOOP-16621.
------------------------------------
    Fix Version/s: 3.3.0
     Hadoop Flags: Reviewed
     Release Note: 
Following APIs have been removed from Token.java to avoid protobuf classes in signature.
1.   o.a.h.security.token.Token(TokenProto tokenPB)
2.   o.a.h.security.token.Token.toTokenProto()
       Resolution: Fixed

Merged PR to trunk.
Thanks [~stevel@apache.org] and [~ayushtkn] for reviews. 

> [pb-upgrade] Remove Protobuf classes from signatures of Public APIs
> -------------------------------------------------------------------
>
>                 Key: HADOOP-16621
>                 URL: https://issues.apache.org/jira/browse/HADOOP-16621
>             Project: Hadoop Common
>          Issue Type: Sub-task
>          Components: common
>    Affects Versions: 3.3.0
>            Reporter: Steve Loughran
>            Assignee: Vinayakumar B
>            Priority: Critical
>             Fix For: 3.3.0
>
>
> the move to protobuf 3.x stops spark building because Token has a method which returns a protobuf, and now its returning some v3 types.
> if we want to isolate downstream code from protobuf changes, we need to move that marshalling method from token and put in a helper class.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-dev-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-dev-help@hadoop.apache.org