You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by wj...@apache.org on 2007/03/13 05:00:19 UTC

svn commit: r517516 - /harmony/enhanced/drlvm/trunk/vm/thread/src/thread_native_thin_monitor.c

Author: wjwashburn
Date: Mon Mar 12 21:00:18 2007
New Revision: 517516

URL: http://svn.apache.org/viewvc?view=rev&rev=517516
Log:
Harmony-3001, added //comments on phony race condition that might be
detected by threading tools such as Intel Thread Checker
No lines of real source code were changed
build, build test run on win32 and RHEL 32, gcc 4.0.2


Modified:
    harmony/enhanced/drlvm/trunk/vm/thread/src/thread_native_thin_monitor.c

Modified: harmony/enhanced/drlvm/trunk/vm/thread/src/thread_native_thin_monitor.c
URL: http://svn.apache.org/viewvc/harmony/enhanced/drlvm/trunk/vm/thread/src/thread_native_thin_monitor.c?view=diff&rev=517516&r1=517515&r2=517516
==============================================================================
--- harmony/enhanced/drlvm/trunk/vm/thread/src/thread_native_thin_monitor.c (original)
+++ harmony/enhanced/drlvm/trunk/vm/thread/src/thread_native_thin_monitor.c Mon Mar 12 21:00:18 2007
@@ -244,6 +244,12 @@
     assert(!hythread_is_suspend_enabled());
     assert((UDATA)lockword_ptr > 4);    
     assert(tm_self_tls);
+    
+    // By DRLVM design rules lockword (see description in thin locks paper)
+    // is only modified without compare-and-exchange by owner thread. If tools
+    // like Intel Thread Checker find a bug about this line, it may actually be a 
+    // false-positive.
+
     lockword = *lockword_ptr;       
     lock_id = THREAD_ID(lockword);
     //TRACE(("try lock %x %d", this_id, RECURSION(lockword)));