You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@servicecomb.apache.org by GitBox <gi...@apache.org> on 2019/06/20 07:31:43 UTC
[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull
request #1240: [SCB-1318]RSAProviderTokenManager#validatedToken expired
resource recycling
liubao68 commented on a change in pull request #1240: [SCB-1318]RSAProviderTokenManager#validatedToken expired resource recycling
URL: https://github.com/apache/servicecomb-java-chassis/pull/1240#discussion_r295677045
##########
File path: handlers/handler-publickey-auth/src/main/java/org/apache/servicecomb/authentication/provider/RSAProviderTokenManager.java
##########
@@ -50,7 +52,11 @@ public boolean valid(String token) {
LOGGER.error("token is expired");
return false;
}
- if (validatedToken.contains(rsaToken)) {
+ validatedToken = CacheBuilder.newBuilder()
Review comment:
This logic seems totally wrong, basic tests should be taken.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services