You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/27 17:17:35 UTC

[GitHub] [airflow] potiuk commented on pull request #22509: Make `defer` more tolerant of signature differences in subclasses

potiuk commented on pull request #22509:
URL: https://github.com/apache/airflow/pull/22509#issuecomment-1079977563


   Quite agree with @uranusjr on both accounts. Maybe just documenting those two patterns of making an "operator specific" way of defferal will be enough. I think inheritance and method overriding are generally not very Pythonlc (in this case specifically). Changing method signature in a subclass especially seems like a bad idea.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org