You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/12/27 06:22:08 UTC
[GitHub] [shardingsphere] jiangML opened a new pull request, #23113: Agent: Optimize PluginBootService startup
jiangML opened a new pull request, #23113:
URL: https://github.com/apache/shardingsphere/pull/23113
For #23112.
Changes proposed in this pull request:
- `Agent` starts `PluginBootService` in `Proxy` and `JDBC` mode for unified processing
- Adjust `JDBCBackendTransactionManager` to `BackendTransactionManager`
- Add `MetaDataContextsFactoryAdvice` for`Prometheus` to trigger `Prometheus HTTP server` startup
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] taojintianxia merged pull request #23113: Agent: Optimize PluginBootService startup
Posted by GitBox <gi...@apache.org>.
taojintianxia merged PR #23113:
URL: https://github.com/apache/shardingsphere/pull/23113
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #23113: Agent: Optimize PluginBootService startup
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #23113:
URL: https://github.com/apache/shardingsphere/pull/23113#issuecomment-1365662481
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/23113?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#23113](https://codecov.io/gh/apache/shardingsphere/pull/23113?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c657c82) into [master](https://codecov.io/gh/apache/shardingsphere/commit/7152f64389143f2fbaba62ef1357473cefc8256f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7152f64) will **increase** coverage by `0.05%`.
> The diff coverage is `57.14%`.
```diff
@@ Coverage Diff @@
## master #23113 +/- ##
============================================
+ Coverage 49.95% 50.00% +0.05%
Complexity 2433 2433
============================================
Files 4113 4114 +1
Lines 57502 57492 -10
Branches 9083 9080 -3
============================================
+ Hits 28726 28751 +25
+ Misses 26264 26227 -37
- Partials 2512 2514 +2
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/23113?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ingsphere/agent/bootstrap/ShardingSphereAgent.java](https://codecov.io/gh/apache/shardingsphere/pull/23113/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvU2hhcmRpbmdTcGhlcmVBZ2VudC5qYXZh) | `0.00% <ø> (ø)` | |
| [...trap/plugin/loader/AdvisorConfigurationLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/23113/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvcGx1Z2luL2xvYWRlci9BZHZpc29yQ29uZmlndXJhdGlvbkxvYWRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...agent/bootstrap/spi/PluginBootServiceRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/23113/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvc3BpL1BsdWdpbkJvb3RTZXJ2aWNlUmVnaXN0cnkuamF2YQ==) | `50.00% <ø> (+50.00%)` | :arrow_up: |
| [.../transformer/builder/advise/JDBCAdviceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23113/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvdHJhbnNmb3JtZXIvYnVpbGRlci9hZHZpc2UvSkRCQ0FkdmljZUZhY3RvcnkuamF2YQ==) | `22.22% <0.00%> (+9.72%)` | :arrow_up: |
| [...ics/core/advice/MetaDataContextsFactoryAdvice.java](https://codecov.io/gh/apache/shardingsphere/pull/23113/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvcGx1Z2lucy9tZXRyaWNzL2NvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2FnZW50L21ldHJpY3MvY29yZS9hZHZpY2UvTWV0YURhdGFDb250ZXh0c0ZhY3RvcnlBZHZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../agent/bootstrap/transformer/AgentTransformer.java](https://codecov.io/gh/apache/shardingsphere/pull/23113/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvdHJhbnNmb3JtZXIvQWdlbnRUcmFuc2Zvcm1lci5qYXZh) | `83.33% <100.00%> (+11.90%)` | :arrow_up: |
| [...trap/transformer/builder/advise/AdviceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23113/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvdHJhbnNmb3JtZXIvYnVpbGRlci9hZHZpc2UvQWR2aWNlRmFjdG9yeS5qYXZh) | `83.33% <100.00%> (ø)` | |
| [...transformer/builder/advise/ProxyAdviceFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/23113/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-YWdlbnQvYm9vdHN0cmFwL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9hZ2VudC9ib290c3RyYXAvdHJhbnNmb3JtZXIvYnVpbGRlci9hZHZpc2UvUHJveHlBZHZpY2VGYWN0b3J5LmphdmE=) | `83.33% <100.00%> (+8.33%)` | :arrow_up: |
| [...handler/distsql/ral/hint/enums/HintSourceType.java](https://codecov.io/gh/apache/shardingsphere/pull/23113/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvcHJveHkvYmFja2VuZC9oYW5kbGVyL2Rpc3RzcWwvcmFsL2hpbnQvZW51bXMvSGludFNvdXJjZVR5cGUuamF2YQ==) | `0.00% <0.00%> (-42.86%)` | :arrow_down: |
| ... and [2 more](https://codecov.io/gh/apache/shardingsphere/pull/23113/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org