You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/02/12 16:56:40 UTC
[GitHub] [spark] imback82 commented on a change in pull request #27532:
[SPARK-30782][SQL] Column resolution doesn't respect current
catalog/namespace for v2 tables.
imback82 commented on a change in pull request #27532: [SPARK-30782][SQL] Column resolution doesn't respect current catalog/namespace for v2 tables.
URL: https://github.com/apache/spark/pull/27532#discussion_r378383217
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
##########
@@ -932,8 +934,17 @@ class Analyzer(
case v1Table: V1Table =>
v1SessionCatalog.getRelation(v1Table.v1Table)
case table =>
+ // Note that SessionCatalogAndIdentifier doesn't update the namespace if the resolved
+ // identifier has a single-part name because it could reference a temp view which does
+ // not belong to any namespaces. For v1 tables, namespace is resolved in
+ // `SessionCatalog.getRelation`.
+ val ns = if (ident.namespace.isEmpty) {
+ catalogManager.currentNamespace
Review comment:
Good catch! I will take a look at the PR. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org