You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/05/14 12:52:38 UTC

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #7156: ARROW-8047: [C++][Dataset][Python] FileFragments from buffers and NativeFiles

jorisvandenbossche commented on a change in pull request #7156:
URL: https://github.com/apache/arrow/pull/7156#discussion_r425111285



##########
File path: python/pyarrow/dataset.py
##########
@@ -592,9 +596,13 @@ def dataset(source, schema=None, format=None, filesystem=None,
         selector_ignore_prefixes=ignore_prefixes
     )
 
+    import io
+
     # TODO(kszucs): support InMemoryDataset for a table input
     if _is_path_like(source):
         return _filesystem_dataset(source, **kwargs)
+    elif isinstance(source, (io.BytesIO, FileSource)):

Review comment:
       ```suggestion
       elif isinstance(source, (io.BytesIO, FileSource, pa.NativeFile)):
   ```
   
   ?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org