You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2019/11/20 07:19:05 UTC

[GitHub] [incubator-iotdb] HTHou commented on a change in pull request #566: [IOTDB-263] Refactor IoTDBQueryResultSet of JDBC

HTHou commented on a change in pull request #566: [IOTDB-263] Refactor IoTDBQueryResultSet of JDBC
URL: https://github.com/apache/incubator-iotdb/pull/566#discussion_r348322188
 
 

 ##########
 File path: jdbc/src/main/java/org/apache/iotdb/jdbc/IoTDBQueryResultSet.java
 ##########
 @@ -66,6 +67,7 @@
   private final String TIMESTAMP_STR = "Time";
   private static final String limitStr = "LIMIT";
   private static final String offsetStr = "OFFSET";
+  private static final int firstColumnTypeIndex = 2;
 
 Review comment:
   Did you mean also change other constant names like `limitStr` and `offsetStr` to `LIMIT_STR` and `OFFSET_STR`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services