You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by ro...@apache.org on 2022/08/03 10:50:28 UTC

[cloudstack] branch main updated: ui: Close form right after receiving the job id (#6603)

This is an automated email from the ASF dual-hosted git repository.

rohit pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/cloudstack.git


The following commit(s) were added to refs/heads/main by this push:
     new d4d310c790 ui: Close form right after receiving the job id (#6603)
d4d310c790 is described below

commit d4d310c790e32484389b05e88e2960f71fbde3f3
Author: Daniel Augusto Veronezi Salvador <38...@users.noreply.github.com>
AuthorDate: Wed Aug 3 07:50:23 2022 -0300

    ui: Close form right after receiving the job id (#6603)
    
    When restoring and attaching a backup volume, the UI waits for the successfful response of the API to close the formulary. However, letting the form open after sending the command can confuse users, that might try to send the command again.
    
    Note: other formularies (like volume or snapshot creation) always are closed after sending the command to the backend.
    
    With this PR, we intend to close the formulary right after sending the command, as done with others.
    
    Co-authored-by: GutoVeronezi <da...@scclouds.com.br>
---
 ui/src/views/storage/RestoreAttachBackupVolume.vue | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/ui/src/views/storage/RestoreAttachBackupVolume.vue b/ui/src/views/storage/RestoreAttachBackupVolume.vue
index 31f6b1c817..41a8f76298 100644
--- a/ui/src/views/storage/RestoreAttachBackupVolume.vue
+++ b/ui/src/views/storage/RestoreAttachBackupVolume.vue
@@ -162,12 +162,10 @@ export default {
               jobId,
               title,
               description: values.volumeid,
-              successMethod: result => {
-                this.closeAction()
-              },
               loadingMessage: `${title} ${this.$t('label.in.progress.for')} ${this.resource.id}`,
               catchMessage: this.$t('error.fetching.async.job.result')
             })
+            this.closeAction()
           }
         }).catch(error => {
           this.$notifyError(error)