You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/06 10:16:34 UTC
[GitHub] [airflow] mik-laj opened a new issue #11297: Strict type hints for Amazon
mik-laj opened a new issue #11297:
URL: https://github.com/apache/airflow/issues/11297
**Description**
The [`boto3`](https://boto3.amazonaws.com/v1/documentation/api/latest/index.html) used by Amazon provider generates new classes at runtime, so mypy is not aware of types. Luckily, there is a package that has generated type annotations, but we have to install them separately - https://pypi.org/project/boto3-stubs/
It would be nice for us to check if this library meets our expectations and integrate it with our CI.
CC: @kaxil @mlgruby @coopergillan
**Use case / motivation**
This will allow us to detect more problems during the static check. It will also provide a better development experience as the IDE will be able to suggest types.
**Related Issues**
N/A
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mlgruby commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
mlgruby commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-704554906
Yup, just gonna do some checks and then switch to other type hints 🙂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] scrambldchannel commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
scrambldchannel commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-707163976
I'm interested in helping with this too, I was just looking at the AWS provider typehints and came across the same library.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mlgruby commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
mlgruby commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-742473893
I have started to work on this, sorry initially got distracted by professional work. I might shout out for help later. But for now I am good.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-709403226
Go for it @potix2 if you would like to create PR, take https://github.com/apache/airflow/pull/11470 as an example
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potix2 commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
potix2 commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-709440687
I'm working on #11531. But I feel it's too large to ask for review. Should I divide into some small requests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-714086523
@potix2 @mlgruby @scrambldchannel I assigned you to this ticket 🐱
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-864498645
boto3_type_annotations is deprecated. We should use boto3-stubs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] coopergillan commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
coopergillan commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-864488490
@mik-laj - came back to this after seeing a new comment on an old PR: https://github.com/apache/airflow/pull/10164/files#r653685526
It looks like [`boto3_type_annotations`](https://github.com/alliefitter/boto3_type_annotations) is another option in addition to `boto3-stubs` as you mention.
Do you have a preference? Do you know if either of these have yet been installed? Guessing no.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potix2 commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
potix2 commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-745744502
I'm working on #10742, but it's a little harder than I expected. After complete it, I'll be back to this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-704188931
> Since you mentioned in last issue comment I had a look and it make sense to try it here.
>
> I can have a look.
Cool, thanks. Not super important, this can wait if you'd like to work on other Type hints first. Completely up to you :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-711266686
> I'm working on #11531. But I feel it's too large to ask for review. Should I divide into some small requests?
Sure got for it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mlgruby commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
mlgruby commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-704182252
Since you mentioned in last issue comment I had a look and it make sense to try it here.
I can have a look.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
mik-laj commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-742462405
@potix2 @mlgruby @scrambldchannel Do you need any help? If you have any questions about this ticket, I will be happy to explain.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potix2 commented on issue #11297: More type hints for Amazon provider
Posted by GitBox <gi...@apache.org>.
potix2 commented on issue #11297:
URL: https://github.com/apache/airflow/issues/11297#issuecomment-709398872
I'm interested in this issue too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org