You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Yifan Zhang (Code Review)" <ge...@cloudera.org> on 2023/04/24 09:54:48 UTC
[Impala-ASF-CR] IMPALA-12085: Update comments in cluster-membership-mgr.h
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/19788
Change subject: IMPALA-12085: Update comments in cluster-membership-mgr.h
......................................................................
IMPALA-12085: Update comments in cluster-membership-mgr.h
As IMPALA-8484 has been resolved, outdated comments in
cluster-membership-mgr.h should be removed.
Change-Id: Iff08e39c1f01ef664629f94d23f0d73037f83dca
---
M be/src/scheduling/cluster-membership-mgr.h
1 file changed, 1 insertion(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/19788/1
--
To view, visit http://gerrit.cloudera.org:8080/19788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff08e39c1f01ef664629f94d23f0d73037f83dca
Gerrit-Change-Number: 19788
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
[Impala-ASF-CR] IMPALA-12085: Update comments in cluster-membership-mgr.h
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/19788 )
Change subject: IMPALA-12085: Update comments in cluster-membership-mgr.h
......................................................................
Patch Set 2: Code-Review+2
carry +1 from Michael
--
To view, visit http://gerrit.cloudera.org:8080/19788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff08e39c1f01ef664629f94d23f0d73037f83dca
Gerrit-Change-Number: 19788
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Apr 2023 18:52:57 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12085: Update comments in cluster-membership-mgr.h
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/19788 )
Change subject: IMPALA-12085: Update comments in cluster-membership-mgr.h
......................................................................
IMPALA-12085: Update comments in cluster-membership-mgr.h
As IMPALA-8484 has been resolved, outdated comments in
cluster-membership-mgr.h should be removed.
This patch contains no functional changes.
Change-Id: Iff08e39c1f01ef664629f94d23f0d73037f83dca
Reviewed-on: http://gerrit.cloudera.org:8080/19788
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/scheduling/cluster-membership-mgr.h
1 file changed, 1 insertion(+), 6 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/19788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iff08e39c1f01ef664629f94d23f0d73037f83dca
Gerrit-Change-Number: 19788
Gerrit-PatchSet: 4
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-12085: Update comments in cluster-membership-mgr.h
Posted by "Michael Smith (Code Review)" <ge...@cloudera.org>.
Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/19788 )
Change subject: IMPALA-12085: Update comments in cluster-membership-mgr.h
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/19788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff08e39c1f01ef664629f94d23f0d73037f83dca
Gerrit-Change-Number: 19788
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Apr 2023 18:10:54 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12085: Update comments in cluster-membership-mgr.h
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19788 )
Change subject: IMPALA-12085: Update comments in cluster-membership-mgr.h
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/19788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff08e39c1f01ef664629f94d23f0d73037f83dca
Gerrit-Change-Number: 19788
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Tue, 25 Apr 2023 00:15:02 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12085: Update comments in cluster-membership-mgr.h
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19788 )
Change subject: IMPALA-12085: Update comments in cluster-membership-mgr.h
......................................................................
Patch Set 3:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/9251/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/19788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff08e39c1f01ef664629f94d23f0d73037f83dca
Gerrit-Change-Number: 19788
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Apr 2023 18:53:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12085: Update comments in cluster-membership-mgr.h
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19788 )
Change subject: IMPALA-12085: Update comments in cluster-membership-mgr.h
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/19788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff08e39c1f01ef664629f94d23f0d73037f83dca
Gerrit-Change-Number: 19788
Gerrit-PatchSet: 3
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Michael Smith <mi...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Apr 2023 18:53:52 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12085: Update comments in cluster-membership-mgr.h
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/19788 )
Change subject: IMPALA-12085: Update comments in cluster-membership-mgr.h
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/12844/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/19788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iff08e39c1f01ef664629f94d23f0d73037f83dca
Gerrit-Change-Number: 19788
Gerrit-PatchSet: 1
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 24 Apr 2023 10:15:29 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-12085: Update comments in cluster-membership-mgr.h
Posted by "Yifan Zhang (Code Review)" <ge...@cloudera.org>.
Hello Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/19788
to look at the new patch set (#2).
Change subject: IMPALA-12085: Update comments in cluster-membership-mgr.h
......................................................................
IMPALA-12085: Update comments in cluster-membership-mgr.h
As IMPALA-8484 has been resolved, outdated comments in
cluster-membership-mgr.h should be removed.
This patch contains no functional changes.
Change-Id: Iff08e39c1f01ef664629f94d23f0d73037f83dca
---
M be/src/scheduling/cluster-membership-mgr.h
1 file changed, 1 insertion(+), 6 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/88/19788/2
--
To view, visit http://gerrit.cloudera.org:8080/19788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iff08e39c1f01ef664629f94d23f0d73037f83dca
Gerrit-Change-Number: 19788
Gerrit-PatchSet: 2
Gerrit-Owner: Yifan Zhang <ch...@163.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>