You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Bannier <bb...@apache.org> on 2019/07/30 21:01:28 UTC
Review Request 71206: Removed old mesos-style and references.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71206/
-----------------------------------------------------------
Review request for mesos and Till Toenshoff.
Bugs: MESOS-9360
https://issues.apache.org/jira/browse/MESOS-9360
Repository: mesos
Description
-------
This patch removes references to `support/mesos-style.py` which was
replaced with a pre-commit setup in a previous commit. We also remove
the tool itself.
Diffs
-----
docs/c++-style-guide.md 8a48afe780f23736c9b7abeb7337977521cecfa5
support/build-virtualenv 7dc03b054f7663979e4eb4b11ad51d759b7f1ad3
support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725
support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a
support/hooks/pre-commit 519567bf5f20a74b273c8d8514577fe4342dc45d
support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27
Diff: https://reviews.apache.org/r/71206/diff/1/
Testing
-------
n/a
Thanks,
Benjamin Bannier
Re: Review Request 71206: Removed old mesos-style and references.
Posted by Joseph Wu <jo...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71206/#review217463
-----------------------------------------------------------
Ship it!
Ship It!
- Joseph Wu
On Aug. 20, 2019, 4:49 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71206/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2019, 4:49 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch removes references to `support/mesos-style.py` which was
> replaced with a pre-commit setup in a previous commit. We also remove
> the tool itself.
>
>
> Diffs
> -----
>
> docs/c++-style-guide.md 8a48afe780f23736c9b7abeb7337977521cecfa5
> support/build-virtualenv 7dc03b054f7663979e4eb4b11ad51d759b7f1ad3
> support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725
> support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a
> support/hooks/pre-commit 519567bf5f20a74b273c8d8514577fe4342dc45d
> support/mesos-split.py 0a77c257386ffe576abd12f59f926640836ad900
> support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27
>
>
> Diff: https://reviews.apache.org/r/71206/diff/5/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71206: Removed old mesos-style and references.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71206/#review217444
-----------------------------------------------------------
Ship it!
- Till Toenshoff
On Aug. 20, 2019, 11:49 a.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71206/
> -----------------------------------------------------------
>
> (Updated Aug. 20, 2019, 11:49 a.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch removes references to `support/mesos-style.py` which was
> replaced with a pre-commit setup in a previous commit. We also remove
> the tool itself.
>
>
> Diffs
> -----
>
> docs/c++-style-guide.md 8a48afe780f23736c9b7abeb7337977521cecfa5
> support/build-virtualenv 7dc03b054f7663979e4eb4b11ad51d759b7f1ad3
> support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725
> support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a
> support/hooks/pre-commit 519567bf5f20a74b273c8d8514577fe4342dc45d
> support/mesos-split.py 0a77c257386ffe576abd12f59f926640836ad900
> support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27
>
>
> Diff: https://reviews.apache.org/r/71206/diff/5/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71206: Removed old mesos-style and references.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71206/
-----------------------------------------------------------
(Updated Aug. 20, 2019, 1:49 p.m.)
Review request for mesos and Till Toenshoff.
Changes
-------
Address comments from bennoe & jpeach offline
Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630
Repository: mesos
Description
-------
This patch removes references to `support/mesos-style.py` which was
replaced with a pre-commit setup in a previous commit. We also remove
the tool itself.
Diffs (updated)
-----
docs/c++-style-guide.md 8a48afe780f23736c9b7abeb7337977521cecfa5
support/build-virtualenv 7dc03b054f7663979e4eb4b11ad51d759b7f1ad3
support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725
support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a
support/hooks/pre-commit 519567bf5f20a74b273c8d8514577fe4342dc45d
support/mesos-split.py 0a77c257386ffe576abd12f59f926640836ad900
support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27
Diff: https://reviews.apache.org/r/71206/diff/5/
Changes: https://reviews.apache.org/r/71206/diff/4-5/
Testing
-------
n/a
Thanks,
Benjamin Bannier
Re: Review Request 71206: Removed old mesos-style and references.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71206/#review217279
-----------------------------------------------------------
Fix it, then Ship it!
docs/c++-style-guide.md
Line 10 (original), 10 (patched)
<https://reviews.apache.org/r/71206/#comment304576>
s/script/command/
support/mesos-style.py
Line 28 (original), 25 (patched)
<https://reviews.apache.org/r/71206/#comment304577>
This is probably going to be the first point of contact with the new linting system for most developers, so it might pay to be a bit more verbose, e.g. mention that you can install `pre-commit` via pip and add links to the pre-commit website, mailing list or JIRA tickets, etc.
However, it's essentially a judgment call so I'll leave it up to you :D
- Benno Evers
On Aug. 16, 2019, 7:42 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71206/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2019, 7:42 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch removes references to `support/mesos-style.py` which was
> replaced with a pre-commit setup in a previous commit. We also remove
> the tool itself.
>
>
> Diffs
> -----
>
> docs/c++-style-guide.md 8a48afe780f23736c9b7abeb7337977521cecfa5
> support/build-virtualenv 7dc03b054f7663979e4eb4b11ad51d759b7f1ad3
> support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725
> support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a
> support/hooks/pre-commit 519567bf5f20a74b273c8d8514577fe4342dc45d
> support/mesos-split.py 0a77c257386ffe576abd12f59f926640836ad900
> support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27
>
>
> Diff: https://reviews.apache.org/r/71206/diff/4/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71206: Removed old mesos-style and references.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71206/#review217267
-----------------------------------------------------------
Ship it!
Ship It!
- James Peach
On Aug. 16, 2019, 7:42 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71206/
> -----------------------------------------------------------
>
> (Updated Aug. 16, 2019, 7:42 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch removes references to `support/mesos-style.py` which was
> replaced with a pre-commit setup in a previous commit. We also remove
> the tool itself.
>
>
> Diffs
> -----
>
> docs/c++-style-guide.md 8a48afe780f23736c9b7abeb7337977521cecfa5
> support/build-virtualenv 7dc03b054f7663979e4eb4b11ad51d759b7f1ad3
> support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725
> support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a
> support/hooks/pre-commit 519567bf5f20a74b273c8d8514577fe4342dc45d
> support/mesos-split.py 0a77c257386ffe576abd12f59f926640836ad900
> support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27
>
>
> Diff: https://reviews.apache.org/r/71206/diff/4/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Benjamin Bannier
>
>
Re: Review Request 71206: Removed old mesos-style and references.
Posted by Benjamin Bannier <bb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71206/
-----------------------------------------------------------
(Updated Aug. 16, 2019, 9:42 p.m.)
Review request for mesos and Till Toenshoff.
Bugs: MESOS-9360
https://issues.apache.org/jira/browse/MESOS-9360
Repository: mesos
Description
-------
This patch removes references to `support/mesos-style.py` which was
replaced with a pre-commit setup in a previous commit. We also remove
the tool itself.
Diffs (updated)
-----
docs/c++-style-guide.md 8a48afe780f23736c9b7abeb7337977521cecfa5
support/build-virtualenv 7dc03b054f7663979e4eb4b11ad51d759b7f1ad3
support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725
support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a
support/hooks/pre-commit 519567bf5f20a74b273c8d8514577fe4342dc45d
support/mesos-split.py 0a77c257386ffe576abd12f59f926640836ad900
support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27
Diff: https://reviews.apache.org/r/71206/diff/3/
Changes: https://reviews.apache.org/r/71206/diff/2-3/
Testing
-------
n/a
Thanks,
Benjamin Bannier
Re: Review Request 71206: Removed old mesos-style and references.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71206/#review217199
-----------------------------------------------------------
After applying this series for testing purposes, I ran into a problem where `mesos-style.py` was still referenced from a git hook, breaking my ability to commit without non-trivial investigation of the problem. (and I had the advantage of *knowing* that I just applied this patch series, if we commit it to master some other developers will be caught by suprise, no matter how heavily it is advertised.)
I'd suggest instead of removing `mesos-style.py` outright, we replace it with a simple bash script that just prints something like `WARNING: 'mesos-style.py' is not supported anymore and does nothing, please fix whatever was calling this script. See MESOS-9630.`
- Benno Evers
On July 30, 2019, 9:01 p.m., Benjamin Bannier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71206/
> -----------------------------------------------------------
>
> (Updated July 30, 2019, 9:01 p.m.)
>
>
> Review request for mesos and Till Toenshoff.
>
>
> Bugs: MESOS-9360
> https://issues.apache.org/jira/browse/MESOS-9360
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch removes references to `support/mesos-style.py` which was
> replaced with a pre-commit setup in a previous commit. We also remove
> the tool itself.
>
>
> Diffs
> -----
>
> docs/c++-style-guide.md 8a48afe780f23736c9b7abeb7337977521cecfa5
> support/build-virtualenv 7dc03b054f7663979e4eb4b11ad51d759b7f1ad3
> support/hooks/commit-msg a0c218deee3fb4b7594fe39b76c1025045ba0725
> support/hooks/post-rewrite 1ab14abf711d1923a7ae69beb33581317009a94a
> support/hooks/pre-commit 519567bf5f20a74b273c8d8514577fe4342dc45d
> support/mesos-style.py cd490bd3deeb8477295bbad010f36d984ce17d27
>
>
> Diff: https://reviews.apache.org/r/71206/diff/1/
>
>
> Testing
> -------
>
> n/a
>
>
> Thanks,
>
> Benjamin Bannier
>
>