You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by br...@apache.org on 2018/12/11 22:36:15 UTC
[cordova-node-xcode] branch brodybits-introduce-eslint created (now
197fc85)
This is an automated email from the ASF dual-hosted git repository.
brodybits pushed a change to branch brodybits-introduce-eslint
in repository https://gitbox.apache.org/repos/asf/cordova-node-xcode.git.
at 197fc85 [TODO] TBD RULES DISABLED in lib & test for now
This branch includes the following new commits:
new 965663c Introduce eslint
new 197fc85 [TODO] TBD RULES DISABLED in lib & test for now
The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails. The revisions
listed as "add" were already present in the repository and have only
been added to this reference.
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-node-xcode] 02/02: [TODO] TBD RULES DISABLED in lib & test
for now
Posted by br...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
brodybits pushed a commit to branch brodybits-introduce-eslint
in repository https://gitbox.apache.org/repos/asf/cordova-node-xcode.git
commit 197fc852a73e28cc2a555ddb321655d67ff04f10
Author: Christopher J. Brody <ch...@gmail.com>
AuthorDate: Tue Dec 11 17:32:35 2018 -0500
[TODO] TBD RULES DISABLED in lib & test for now
TODO: start resolving eslint issues in lib & test
so that we can remove the disabled rule entries.
---
lib/.eslintrc.yml | 33 +++++++++++++++++++++++++++++++++
test/.eslintrc.yml | 34 ++++++++++++++++++++++++++++++++++
2 files changed, 67 insertions(+)
diff --git a/lib/.eslintrc.yml b/lib/.eslintrc.yml
new file mode 100644
index 0000000..6ebbaeb
--- /dev/null
+++ b/lib/.eslintrc.yml
@@ -0,0 +1,33 @@
+rules:
+ # TODO: Resolve the issues in the code so that these rules can be re-enabled.
+ brace-style: off
+ comma-dangle: off
+ curly: off
+ eqeqeq: off
+ func-call-spacing: off
+ indent: off
+ key-spacing: off
+ keyword-spacing: off
+ new-cap: off
+ no-dupe-keys: off
+ no-extra-semi: off
+ no-mixed-operators: off
+ no-multi-spaces: off
+ no-multiple-empty-lines: off
+ no-new-object: off
+ no-path-concat: off
+ no-redeclare: off
+ no-trailing-spaces: off
+ no-undef: off
+ no-unneeded-ternary: off
+ no-unused-vars: off
+ object-curly-spacing: off
+ one-var: off
+ quotes: off
+ semi: off
+ space-before-blocks: off
+ space-before-function-paren: off
+ space-in-parens: off
+ space-infix-ops: off
+ spaced-comment: off
+ standard/object-curly-even-spacing: off
diff --git a/test/.eslintrc.yml b/test/.eslintrc.yml
new file mode 100644
index 0000000..27e9b28
--- /dev/null
+++ b/test/.eslintrc.yml
@@ -0,0 +1,34 @@
+rules:
+ # TODO: Resolve the issues in the code so that these rules can be re-enabled.
+ comma-dangle: off
+ comma-spacing: off
+ comma-style: off
+ curly: off
+ eqeqeq: off
+ func-call-spacing: off
+ handle-callback-err: off
+ indent: off
+ key-spacing: off
+ new-cap: off
+ no-multi-spaces: off
+ no-multiple-empty-lines: off
+ no-path-concat: off
+ no-redeclare: off
+ no-regex-spaces: off
+ no-sequences: off
+ no-tabs: off
+ no-template-curly-in-string: off
+ no-trailing-spaces: off
+ no-undef: off
+ no-unused-expressions: off
+ no-unused-vars: off
+ no-use-before-define: off
+ object-curly-spacing: off
+ one-var: off
+ quotes: off
+ semi: off
+ space-before-blocks: off
+ space-before-function-paren: off
+ space-in-parens: off
+ space-infix-ops: off
+ standard/object-curly-even-spacing: off
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[cordova-node-xcode] 01/02: Introduce eslint
Posted by br...@apache.org.
This is an automated email from the ASF dual-hosted git repository.
brodybits pushed a commit to branch brodybits-introduce-eslint
in repository https://gitbox.apache.org/repos/asf/cordova-node-xcode.git
commit 965663ceeea3123e2e3014383187342d36dea0ff
Author: Christopher J. Brody <ch...@gmail.com>
AuthorDate: Tue Dec 11 17:14:18 2018 -0500
Introduce eslint
with .eslintrc.yml copied from cordova-common
Co-authored-by: Audrey So <au...@apache.org>
Co-authored-by: Raphael von der Grün <ra...@gmail.com>
Co-authored-by: Christopher J. Brody <ch...@gmail.com>
---
.eslintignore | 1 +
.eslintrc.yml | 13 +++++++++++++
package.json | 10 +++++++++-
3 files changed, 23 insertions(+), 1 deletion(-)
diff --git a/.eslintignore b/.eslintignore
new file mode 100644
index 0000000..8a231cb
--- /dev/null
+++ b/.eslintignore
@@ -0,0 +1 @@
+lib/parser
diff --git a/.eslintrc.yml b/.eslintrc.yml
new file mode 100644
index 0000000..21a8e7b
--- /dev/null
+++ b/.eslintrc.yml
@@ -0,0 +1,13 @@
+root: true
+extends: semistandard
+rules:
+ indent:
+ - error
+ - 4
+ camelcase: off
+ padded-blocks: off
+ operator-linebreak: off
+ no-throw-literal: off
+ no-unused-vars:
+ - error
+ - args: after-used
diff --git a/package.json b/package.json
index 7fc751e..b46b8a2 100644
--- a/package.json
+++ b/package.json
@@ -15,12 +15,20 @@
"uuid": "3.0.1"
},
"devDependencies": {
+ "eslint": "^5.10.0",
+ "eslint-config-semistandard": "^13.0.0",
+ "eslint-config-standard": "^12.0.0",
+ "eslint-plugin-import": "^2.14.0",
+ "eslint-plugin-node": "^8.0.0",
+ "eslint-plugin-promise": "^4.0.1",
+ "eslint-plugin-standard": "^4.0.0",
"nodeunit": "^0.11.3",
"pegjs": "^0.10.0"
},
"scripts": {
+ "eslint": "eslint lib test",
"pegjs": "node_modules/.bin/pegjs lib/parser/pbxproj.pegjs",
- "test": "node_modules/.bin/nodeunit test/parser test"
+ "test": "node_modules/.bin/nodeunit test/parser test && npm run eslint"
},
"license": "Apache-2.0",
"contributors": [
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org