You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/07/05 09:11:19 UTC
[GitHub] [spark] HyukjinKwon opened a new pull request, #37084: [SPARK-39612][SQL][TESTS] DataFrame.exceptAll followed by count should work
HyukjinKwon opened a new pull request, #37084:
URL: https://github.com/apache/spark/pull/37084
### What changes were proposed in this pull request?
This PR adds a test case broken by https://github.com/apache/spark/commit/4b9343593eca780ca30ffda45244a71413577884 which was reverted in https://github.com/apache/spark/commit/161c596cafea9c235b5c918d8999c085401d73a9.
### Why are the changes needed?
To prevent a regression in the future. This was a regression in Apache Spark 3.3 that used to work in Apache Spark 3.2.
### Does this PR introduce _any_ user-facing change?
Yes, it makes `DataFrame.exceptAll` followed by `count` works.
### How was this patch tested?
The unit test was added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #37084: [SPARK-39612][SQL][TESTS] DataFrame.exceptAll followed by count should work
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #37084:
URL: https://github.com/apache/spark/pull/37084#issuecomment-1174964501
All passed.
Merged to master and branch-3.3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #37084: [SPARK-39612][SQL][TESTS] DataFrame.exceptAll followed by count should work
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #37084: [SPARK-39612][SQL][TESTS] DataFrame.exceptAll followed by count should work
URL: https://github.com/apache/spark/pull/37084
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org