You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/10/22 09:44:50 UTC

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3997: New API endpoint: UpdateVlanIpRange

DaanHoogland commented on a change in pull request #3997:
URL: https://github.com/apache/cloudstack/pull/3997#discussion_r510026508



##########
File path: api/src/main/java/com/cloud/configuration/ConfigurationService.java
##########
@@ -274,18 +274,12 @@ Vlan createVlanAndPublicIpRange(CreateVlanIpRangeCmd cmd) throws InsufficientCap
         ResourceAllocationException;
 
     /**
-     * Updates the IP address Range for the VLAN on the database, a
-     *
+     * Updates the IP address Range for the VLAN on the database
      * @param cmd
-     * @param vlanId
-     * @param gateway
-     * @param startIP
-     * @param endIP
-     * @param netmask
-     * @throws com.cloud.exception.ConcurrentOperationException
-     * @throws com.cloud.exception.ResourceUnavailableException
-     * @throws com.cloud.exception.ResourceAllocationException
-     * @return The updated Vlan object
+     * @return
+     * @throws ConcurrentOperationException
+     * @throws ResourceUnavailableException
+     * @throws ResourceAllocationException

Review comment:
       why leave these empty items?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org