You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2019/07/02 17:53:06 UTC
Re: Review Request 70797: Added unit tests for hostname validation.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70797/
-----------------------------------------------------------
(Updated July 2, 2019, 5:53 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Joseph Wu, and Till Toenshoff.
Repository: mesos
Description (updated)
-------
This commit adds some unit tests to verify the newly added `hostname_validation_scheme` flag is working as intended.
While going through the existing tests to look for candidates
that would benefit from being tested for both hostname validation
schemes, I noticed a number of existing tests where test setup
did not quite match the comment or test name. I fixed these up
in this review as well.
Diffs (updated)
-----
3rdparty/libprocess/include/process/ssl/gtest.hpp 6cdd7815f4389cd398defe56260a73eb710a4d8f
3rdparty/libprocess/src/tests/ssl_client.cpp de87b3b89c84d17f2ebba1f09e9ec682f139aace
3rdparty/libprocess/src/tests/ssl_tests.cpp 5d360221937e68da185754f0633fa41a217c7107
Diff: https://reviews.apache.org/r/70797/diff/5/
Changes: https://reviews.apache.org/r/70797/diff/4-5/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70797: Added unit tests for hostname validation.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70797/#review216379
-----------------------------------------------------------
Ship it!
Ship It!
- Till Toenshoff
On July 2, 2019, 5:53 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70797/
> -----------------------------------------------------------
>
> (Updated July 2, 2019, 5:53 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Joseph Wu, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit adds some unit tests to verify the newly added `hostname_validation_scheme` flag is working as intended.
>
> While going through the existing tests to look for candidates
> that would benefit from being tested for both hostname validation
> schemes, I noticed a number of existing tests where test setup
> did not quite match the comment or test name. I fixed these up
> in this review as well.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/ssl/gtest.hpp 6cdd7815f4389cd398defe56260a73eb710a4d8f
> 3rdparty/libprocess/src/tests/ssl_client.cpp de87b3b89c84d17f2ebba1f09e9ec682f139aace
> 3rdparty/libprocess/src/tests/ssl_tests.cpp 5d360221937e68da185754f0633fa41a217c7107
>
>
> Diff: https://reviews.apache.org/r/70797/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 70797: Added unit tests for hostname validation.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70797/
-----------------------------------------------------------
(Updated July 4, 2019, 7 p.m.)
Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Joseph Wu, and Till Toenshoff.
Changes
-------
Renamed `libprocess` -> `legacy`.
Repository: mesos
Description (updated)
-------
While going through the existing tests to look for candidates
that would benefit from being tested for both hostname validation
schemes, I noticed a number of existing tests where test setup
did not quite match the comment or test name. I fixed these up
in the same review.
Diffs (updated)
-----
3rdparty/libprocess/include/process/ssl/gtest.hpp 6cdd7815f4389cd398defe56260a73eb710a4d8f
3rdparty/libprocess/src/tests/ssl_client.cpp de87b3b89c84d17f2ebba1f09e9ec682f139aace
3rdparty/libprocess/src/tests/ssl_tests.cpp 5d360221937e68da185754f0633fa41a217c7107
Diff: https://reviews.apache.org/r/70797/diff/6/
Changes: https://reviews.apache.org/r/70797/diff/5-6/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 70797: Added unit tests for hostname validation.
Posted by Till Toenshoff via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70797/#review216378
-----------------------------------------------------------
3rdparty/libprocess/src/tests/ssl_tests.cpp
Line 318 (original), 368 (patched)
<https://reviews.apache.org/r/70797/#comment303597>
s/incorrect/not matching/
- Till Toenshoff
On July 2, 2019, 5:53 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70797/
> -----------------------------------------------------------
>
> (Updated July 2, 2019, 5:53 p.m.)
>
>
> Review request for mesos, Alexander Rukletsov, Benjamin Mahler, Joseph Wu, and Till Toenshoff.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit adds some unit tests to verify the newly added `hostname_validation_scheme` flag is working as intended.
>
> While going through the existing tests to look for candidates
> that would benefit from being tested for both hostname validation
> schemes, I noticed a number of existing tests where test setup
> did not quite match the comment or test name. I fixed these up
> in this review as well.
>
>
> Diffs
> -----
>
> 3rdparty/libprocess/include/process/ssl/gtest.hpp 6cdd7815f4389cd398defe56260a73eb710a4d8f
> 3rdparty/libprocess/src/tests/ssl_client.cpp de87b3b89c84d17f2ebba1f09e9ec682f139aace
> 3rdparty/libprocess/src/tests/ssl_tests.cpp 5d360221937e68da185754f0633fa41a217c7107
>
>
> Diff: https://reviews.apache.org/r/70797/diff/5/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Benno Evers
>
>