You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/01/05 10:44:23 UTC

[GitHub] [rocketmq] chaiyx opened a new pull request #3707: [ISSUE #3706] Update cq minLogicOffset when there is only one expired cq file left

chaiyx opened a new pull request #3707:
URL: https://github.com/apache/rocketmq/pull/3707


   **Make sure set the target branch to `develop`**
   
   ## What is the purpose of the change
   
   #3706
   
   ## Brief changelog
   
   XX
   
   ## Verifying this change
   
   XXXX
   
   Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
   
   - [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. 
   - [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
   - [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
   - [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
   - [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.
   - [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhimins edited a comment on pull request #3707: [ISSUE #3706] Update cq minLogicOffset when there is only one expired cq file left

Posted by GitBox <gi...@apache.org>.
lizhimins edited a comment on pull request #3707:
URL: https://github.com/apache/rocketmq/pull/3707#issuecomment-1012813155






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] coveralls commented on pull request #3707: [ISSUE #3706] Update cq minLogicOffset when there is only one expired cq file left

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #3707:
URL: https://github.com/apache/rocketmq/pull/3707#issuecomment-1005627556


   
   [![Coverage Status](https://coveralls.io/builds/45389367/badge)](https://coveralls.io/builds/45389367)
   
   Coverage decreased (-0.02%) to 53.29% when pulling **a9e9b241f56ccf26331b27198a4f71b4731e8b7b on chaiyx:fix_cq** into **6ebb4e40d4943679d5e37dbc96919e8cfc5808f5 on apache:develop**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhimins commented on pull request #3707: [ISSUE #3706] Update cq minLogicOffset when there is only one expired cq file left

Posted by GitBox <gi...@apache.org>.
lizhimins commented on pull request #3707:
URL: https://github.com/apache/rocketmq/pull/3707#issuecomment-1012813155


   想到了一个更好的办法，在启动时可以通过二分查找的方式定位 consume queue 的 min max offset


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [rocketmq] lizhimins edited a comment on pull request #3707: [ISSUE #3706] Update cq minLogicOffset when there is only one expired cq file left

Posted by GitBox <gi...@apache.org>.
lizhimins edited a comment on pull request #3707:
URL: https://github.com/apache/rocketmq/pull/3707#issuecomment-1012813155


   想到了一个更好的办法，在启动时可以通过二分查找的方式定位 consume queue 的 min max offset
   
   It's a better way to locate the min or max offset of the consumption queue through binary search when broker startup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org