You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/09/23 16:42:17 UTC
[GitHub] [beam] TheNeuralBit commented on a change in pull request #12911: [BEAM-7372][BEAM-8371][BEAM-9372] Sunset Python 2 and Python 3.5 support.
TheNeuralBit commented on a change in pull request #12911:
URL: https://github.com/apache/beam/pull/12911#discussion_r493737145
##########
File path: sdks/python/apache_beam/__init__.py
##########
@@ -94,9 +86,8 @@
pass
else:
raise RuntimeError(
- 'The Apache Beam SDK for Python is only supported on Python 2.7 or '
- 'Python 3. It is not supported on Python [' + str(sys.version_info) +
- '].')
+ 'The Apache Beam SDK for Python is only supported on Python 3. '
+ 'It is not supported on Python [' + str(sys.version_info) + '].')
Review comment:
Should we raise this error (or maybe just the warning above) for <3.6?
##########
File path: release/src/main/python-release/python_release_automation_utils.sh
##########
@@ -78,22 +78,18 @@ function get_version() {
# BEAM_PYTHON_SDK*
# Arguments:
# $1 - SDK type: tar, wheel
-# $2 - python interpreter version: python2.7, python3.5, ...
+# $2 - python interpreter version: python3.7, python3.8, ...
#######################################
function download_files() {
if [[ $1 = *"wheel"* ]]; then
- if [[ $2 == "python2.7" ]]; then
- BEAM_PYTHON_SDK_WHL="apache_beam-$VERSION*-cp27-cp27mu-manylinux1_x86_64.whl"
- elif [[ $2 == "python3.5" ]]; then
- BEAM_PYTHON_SDK_WHL="apache_beam-$VERSION*-cp35-cp35m-manylinux1_x86_64.whl"
- elif [[ $2 == "python3.6" ]]; then
+ if [[ $2 == "python3.6" ]]; then
BEAM_PYTHON_SDK_WHL="apache_beam-$VERSION*-cp36-cp36m-manylinux1_x86_64.whl"
elif [[ $2 == "python3.7" ]]; then
BEAM_PYTHON_SDK_WHL="apache_beam-$VERSION*-cp37-cp37m-manylinux1_x86_64.whl"
elif [[ $2 == "python3.8" ]]; then
- BEAM_PYTHON_SDK_WHL="apache_beam-$VERSION*-cp38-cp38m-manylinux1_x86_64.whl"
+ BEAM_PYTHON_SDK_WHL="apache_beam-$VERSION*-cp38-cp38-manylinux1_x86_64.whl"
elif [[ $2 == "python3.9" ]]; then
- BEAM_PYTHON_SDK_WHL="apache_beam-$VERSION*-cp39-cp39m-manylinux1_x86_64.whl"
+ BEAM_PYTHON_SDK_WHL="apache_beam-$VERSION*-cp39-cp39-manylinux1_x86_64.whl"
Review comment:
Is dropping the `m` here intentional?
##########
File path: .test-infra/jenkins/README.md
##########
@@ -109,7 +109,6 @@ Beam Jenkins overview page: [link](https://ci-beam.apache.org/)
| beam_PerformanceTests_Spark | [cron](https://ci-beam.apache.org/job/beam_PerformanceTests_Spark/) | `Run Spark Performance Test` | [](https://ci-beam.apache.org/job/beam_PerformanceTests_Spark) |
| beam_PerformanceTests_TFRecordIOIT | [cron](https://ci-beam.apache.org/job/beam_PerformanceTests_TFRecordIOIT/) | `Run Java TFRecordIO Performance Test` | [](https://ci-beam.apache.org/job/beam_PerformanceTests_TFRecordIOIT) |
| beam_PerformanceTests_TextIOIT | [cron](https://ci-beam.apache.org/job/beam_PerformanceTests_TextIOIT/), [hdfs_cron](https://ci-beam.apache.org/job/beam_PerformanceTests_TextIOIT_HDFS/) | `Run Java TextIO Performance Test` | [](https://ci-beam.apache.org/job/beam_PerformanceTests_TextIOIT) [](https://ci-beam.apache.org/job/beam_PerformanceTests_TextIOIT_HDFS) |
-| beam_PerformanceTests_WordCountIT_Py27 | [cron](https://ci-beam.apache.org/job/beam_PerformanceTests_WordCountIT_Py27/) | `Run Python27 WordCountIT Performance Test` | [](https://ci-beam.apache.org/job/beam_PerformanceTests_WordCountIT_Py27) |
Review comment:
Could you remove the badges from the README.md and .github/PULL_REQUEST_TEMPLATE.md too?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org